mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2026-01-06 19:02:48 +00:00
8cbcc1dbf8
Commit936874b77d("platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT") added an xarray to track the list of vsec devices to be recovered after a PCI error. But it did not provide cleanup for the list leading to a memory leak that was caught by kmemleak. Do xa_alloc() before devm_add_action_or_reset() so that the list may be cleaned up with xa_erase() in the release function. Fixes:936874b77d("platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT") Signed-off-by: David E. Box <david.e.box@linux.intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20231129222132.2331261-2-david.e.box@linux.intel.com [hdegoede@redhat.com: Add missing xa_erase() on error-exit Signed-off-by: Hans de Goede <hdegoede@redhat.com>
67 lines
1.6 KiB
C
67 lines
1.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _VSEC_H
|
|
#define _VSEC_H
|
|
|
|
#include <linux/auxiliary_bus.h>
|
|
#include <linux/bits.h>
|
|
|
|
#define VSEC_CAP_TELEMETRY BIT(0)
|
|
#define VSEC_CAP_WATCHER BIT(1)
|
|
#define VSEC_CAP_CRASHLOG BIT(2)
|
|
#define VSEC_CAP_SDSI BIT(3)
|
|
#define VSEC_CAP_TPMI BIT(4)
|
|
|
|
struct pci_dev;
|
|
struct resource;
|
|
|
|
enum intel_vsec_quirks {
|
|
/* Watcher feature not supported */
|
|
VSEC_QUIRK_NO_WATCHER = BIT(0),
|
|
|
|
/* Crashlog feature not supported */
|
|
VSEC_QUIRK_NO_CRASHLOG = BIT(1),
|
|
|
|
/* Use shift instead of mask to read discovery table offset */
|
|
VSEC_QUIRK_TABLE_SHIFT = BIT(2),
|
|
|
|
/* DVSEC not present (provided in driver data) */
|
|
VSEC_QUIRK_NO_DVSEC = BIT(3),
|
|
|
|
/* Platforms requiring quirk in the auxiliary driver */
|
|
VSEC_QUIRK_EARLY_HW = BIT(4),
|
|
};
|
|
|
|
/* Platform specific data */
|
|
struct intel_vsec_platform_info {
|
|
struct intel_vsec_header **headers;
|
|
unsigned long caps;
|
|
unsigned long quirks;
|
|
};
|
|
|
|
struct intel_vsec_device {
|
|
struct auxiliary_device auxdev;
|
|
struct pci_dev *pcidev;
|
|
struct resource *resource;
|
|
struct ida *ida;
|
|
struct intel_vsec_platform_info *info;
|
|
int num_resources;
|
|
int id; /* xa */
|
|
void *priv_data;
|
|
size_t priv_data_size;
|
|
};
|
|
|
|
int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
|
|
struct intel_vsec_device *intel_vsec_dev,
|
|
const char *name);
|
|
|
|
static inline struct intel_vsec_device *dev_to_ivdev(struct device *dev)
|
|
{
|
|
return container_of(dev, struct intel_vsec_device, auxdev.dev);
|
|
}
|
|
|
|
static inline struct intel_vsec_device *auxdev_to_ivdev(struct auxiliary_device *auxdev)
|
|
{
|
|
return container_of(auxdev, struct intel_vsec_device, auxdev);
|
|
}
|
|
#endif
|