mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-14 23:04:54 +00:00
8cf5286216
mtk_adsp_ipc_get_data() can return NULL, but the value is not checked
before being used, leading to static analysis warnings.
sound/soc/sof/mediatek/mt8195/mt8195.c:90:32: error: dereference of
NULL ‘0’ [CWE-476] [-Werror=analyzer-null-dereference]
90 | spin_lock_irqsave(&priv->sdev->ipc_lock, flags);
| ~~~~^~~~~~
It appears this is not really a possible problem, so remove those checks.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Yaochun Hung <yc.hung@mediatek.com>
Link: https://lore.kernel.org/r/20230731213748.440285-6-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
60 lines
1.2 KiB
C
60 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2022 MediaTek Inc.
|
|
*/
|
|
|
|
#ifndef MTK_ADSP_IPC_H
|
|
#define MTK_ADSP_IPC_H
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/types.h>
|
|
#include <linux/mailbox_controller.h>
|
|
#include <linux/mailbox_client.h>
|
|
|
|
#define MTK_ADSP_IPC_REQ 0
|
|
#define MTK_ADSP_IPC_RSP 1
|
|
#define MTK_ADSP_IPC_OP_REQ 0x1
|
|
#define MTK_ADSP_IPC_OP_RSP 0x2
|
|
|
|
enum {
|
|
MTK_ADSP_MBOX_REPLY,
|
|
MTK_ADSP_MBOX_REQUEST,
|
|
MTK_ADSP_MBOX_NUM,
|
|
};
|
|
|
|
struct mtk_adsp_ipc;
|
|
|
|
struct mtk_adsp_ipc_ops {
|
|
void (*handle_reply)(struct mtk_adsp_ipc *ipc);
|
|
void (*handle_request)(struct mtk_adsp_ipc *ipc);
|
|
};
|
|
|
|
struct mtk_adsp_chan {
|
|
struct mtk_adsp_ipc *ipc;
|
|
struct mbox_client cl;
|
|
struct mbox_chan *ch;
|
|
char *name;
|
|
int idx;
|
|
};
|
|
|
|
struct mtk_adsp_ipc {
|
|
struct mtk_adsp_chan chans[MTK_ADSP_MBOX_NUM];
|
|
struct device *dev;
|
|
struct mtk_adsp_ipc_ops *ops;
|
|
void *private_data;
|
|
};
|
|
|
|
static inline void mtk_adsp_ipc_set_data(struct mtk_adsp_ipc *ipc, void *data)
|
|
{
|
|
ipc->private_data = data;
|
|
}
|
|
|
|
static inline void *mtk_adsp_ipc_get_data(struct mtk_adsp_ipc *ipc)
|
|
{
|
|
return ipc->private_data;
|
|
}
|
|
|
|
int mtk_adsp_ipc_send(struct mtk_adsp_ipc *ipc, unsigned int idx, uint32_t op);
|
|
|
|
#endif /* MTK_ADSP_IPC_H */
|