Sukadev Bhattiprolu 8878e46fcf ibmvnic: don't stop queue in xmit ... If adapter's resetting bit is on, discard the packet but don't stop the transmit queue - instead leave that to the reset code. With this change, it is possible that we may get several calls to ibmvnic_xmit() that simply discard packets and return. But if we stop the queue here, we might end up doing so just after __ibmvnic_open() started the queues (during a hard/soft reset) and before the ->resetting bit was cleared. If that happens, there will be no one to restart queue and transmissions will be blocked indefinitely. This can cause a TIMEOUT reset and with auto priority failover enabled, an unnecessary FAILOVER reset to less favored backing device and then a FAILOVER back to the most favored backing device. If we hit the window repeatedly, we can get stuck in a loop of TIMEOUT, FAILOVER, FAILOVER resets leaving the adapter unusable for extended periods of time. Fixes: 7f5b030830 ("ibmvnic: Free skb's in cases of failure in transmit") Reported-by: Abdul Haleem <abdhalee@in.ibm.com> Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com> Reviewed-by: Dany Madden <drt@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-11-01 13:14:52 +00:00
..
ehea	ehea: fix error return code in ehea_restart_qps()	2021-05-28 18:12:19 -07:00
emac	dev_ioctl: split out ndo_eth_ioctl	2021-07-27 20:11:45 +01:00
ibmveth.c	dev_ioctl: split out ndo_eth_ioctl	2021-07-27 20:11:45 +01:00
ibmveth.h	net/ethtool: Introduce link_ksettings API for virtual network devices	2020-02-29 21:48:55 -08:00
ibmvnic.c	ibmvnic: don't stop queue in xmit	2021-11-01 13:14:52 +00:00
ibmvnic.h	ibmvnic: Allow device probe if the device is not ready at boot	2021-06-10 14:35:07 -07:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00