mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-15 14:52:38 +00:00
bc3bb79534
We were hardcoding '6' as the max instruction name, and we have lots
that are longer than that, see the diff from two 'P' printed TUI
annotations for a libc function that uses instructions with long names,
such as 'vpmovmskb' with its 9 chars:
--- __strcmp_avx2.annotation.before 2019-03-06 16:31:39.368020425 -0300
+++ __strcmp_avx2.annotation 2019-03-06 16:32:12.079450508 -0300
@@ -2,284 +2,284 @@
Event: cycles:ppp
Percent endbr64
- 0.10 mov %edi,%eax
+ 0.10 mov %edi,%eax
- xor %edx,%edx
+ xor %edx,%edx
- 3.54 vpxor %ymm7,%ymm7,%ymm7
+ 3.54 vpxor %ymm7,%ymm7,%ymm7
- or %esi,%eax
+ or %esi,%eax
- and $0xfff,%eax
+ and $0xfff,%eax
- cmp $0xf80,%eax
+ cmp $0xf80,%eax
- ↓ jg 370
+ ↓ jg 370
- 27.07 vmovdqu (%rdi),%ymm1
+ 27.07 vmovdqu (%rdi),%ymm1
- 7.97 vpcmpeqb (%rsi),%ymm1,%ymm0
+ 7.97 vpcmpeqb (%rsi),%ymm1,%ymm0
- 2.15 vpminub %ymm1,%ymm0,%ymm0
+ 2.15 vpminub %ymm1,%ymm0,%ymm0
- 4.09 vpcmpeqb %ymm7,%ymm0,%ymm0
+ 4.09 vpcmpeqb %ymm7,%ymm0,%ymm0
- 0.43 vpmovmskb %ymm0,%ecx
+ 0.43 vpmovmskb %ymm0,%ecx
- 1.53 test %ecx,%ecx
+ 1.53 test %ecx,%ecx
- ↓ je b0
+ ↓ je b0
- 5.26 tzcnt %ecx,%edx
+ 5.26 tzcnt %ecx,%edx
- 18.40 movzbl (%rdi,%rdx,1),%eax
+ 18.40 movzbl (%rdi,%rdx,1),%eax
- 7.09 movzbl (%rsi,%rdx,1),%edx
+ 7.09 movzbl (%rsi,%rdx,1),%edx
- 3.34 sub %edx,%eax
+ 3.34 sub %edx,%eax
2.37 vzeroupper
← retq
nop
- 50: tzcnt %ecx,%edx
+ 50: tzcnt %ecx,%edx
- movzbl 0x20(%rdi,%rdx,1),%eax
+ movzbl 0x20(%rdi,%rdx,1),%eax
- movzbl 0x20(%rsi,%rdx,1),%edx
+ movzbl 0x20(%rsi,%rdx,1),%edx
- sub %edx,%eax
+ sub %edx,%eax
vzeroupper
← retq
- data16 nopw %cs:0x0(%rax,%rax,1)
+ data16 nopw %cs:0x0(%rax,%rax,1)
Reported-by: Travis Downs <travis.downs@gmail.com>
LPU-Reference: CAOBGo4z1KfmWeOm6Et0cnX5Z6DWsG2PQbAvRn1MhVPJmXHrc5g@mail.gmail.com
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-89wsdd9h9g6bvq52sgp6d0u4@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
122 lines
2.5 KiB
C
122 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/compiler.h>
|
|
#include <sys/types.h>
|
|
#include <regex.h>
|
|
|
|
struct arm64_annotate {
|
|
regex_t call_insn,
|
|
jump_insn;
|
|
};
|
|
|
|
static int arm64_mov__parse(struct arch *arch __maybe_unused,
|
|
struct ins_operands *ops,
|
|
struct map_symbol *ms __maybe_unused)
|
|
{
|
|
char *s = strchr(ops->raw, ','), *target, *endptr;
|
|
|
|
if (s == NULL)
|
|
return -1;
|
|
|
|
*s = '\0';
|
|
ops->source.raw = strdup(ops->raw);
|
|
*s = ',';
|
|
|
|
if (ops->source.raw == NULL)
|
|
return -1;
|
|
|
|
target = ++s;
|
|
ops->target.raw = strdup(target);
|
|
if (ops->target.raw == NULL)
|
|
goto out_free_source;
|
|
|
|
ops->target.addr = strtoull(target, &endptr, 16);
|
|
if (endptr == target)
|
|
goto out_free_target;
|
|
|
|
s = strchr(endptr, '<');
|
|
if (s == NULL)
|
|
goto out_free_target;
|
|
endptr = strchr(s + 1, '>');
|
|
if (endptr == NULL)
|
|
goto out_free_target;
|
|
|
|
*endptr = '\0';
|
|
*s = ' ';
|
|
ops->target.name = strdup(s);
|
|
*s = '<';
|
|
*endptr = '>';
|
|
if (ops->target.name == NULL)
|
|
goto out_free_target;
|
|
|
|
return 0;
|
|
|
|
out_free_target:
|
|
zfree(&ops->target.raw);
|
|
out_free_source:
|
|
zfree(&ops->source.raw);
|
|
return -1;
|
|
}
|
|
|
|
static int mov__scnprintf(struct ins *ins, char *bf, size_t size,
|
|
struct ins_operands *ops, int max_ins_name);
|
|
|
|
static struct ins_ops arm64_mov_ops = {
|
|
.parse = arm64_mov__parse,
|
|
.scnprintf = mov__scnprintf,
|
|
};
|
|
|
|
static struct ins_ops *arm64__associate_instruction_ops(struct arch *arch, const char *name)
|
|
{
|
|
struct arm64_annotate *arm = arch->priv;
|
|
struct ins_ops *ops;
|
|
regmatch_t match[2];
|
|
|
|
if (!regexec(&arm->jump_insn, name, 2, match, 0))
|
|
ops = &jump_ops;
|
|
else if (!regexec(&arm->call_insn, name, 2, match, 0))
|
|
ops = &call_ops;
|
|
else if (!strcmp(name, "ret"))
|
|
ops = &ret_ops;
|
|
else
|
|
ops = &arm64_mov_ops;
|
|
|
|
arch__associate_ins_ops(arch, name, ops);
|
|
return ops;
|
|
}
|
|
|
|
static int arm64__annotate_init(struct arch *arch, char *cpuid __maybe_unused)
|
|
{
|
|
struct arm64_annotate *arm;
|
|
int err;
|
|
|
|
if (arch->initialized)
|
|
return 0;
|
|
|
|
arm = zalloc(sizeof(*arm));
|
|
if (!arm)
|
|
return -1;
|
|
|
|
/* bl, blr */
|
|
err = regcomp(&arm->call_insn, "^blr?$", REG_EXTENDED);
|
|
if (err)
|
|
goto out_free_arm;
|
|
/* b, b.cond, br, cbz/cbnz, tbz/tbnz */
|
|
err = regcomp(&arm->jump_insn, "^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|le|ls|lt|mi|ne|pl)?n?z?$",
|
|
REG_EXTENDED);
|
|
if (err)
|
|
goto out_free_call;
|
|
|
|
arch->initialized = true;
|
|
arch->priv = arm;
|
|
arch->associate_instruction_ops = arm64__associate_instruction_ops;
|
|
arch->objdump.comment_char = '/';
|
|
arch->objdump.skip_functions_char = '+';
|
|
return 0;
|
|
|
|
out_free_call:
|
|
regfree(&arm->call_insn);
|
|
out_free_arm:
|
|
free(arm);
|
|
return -1;
|
|
}
|