Michal Swiatkowski b3e7b3a6ee ice: prevent NULL pointer deref during reload ... Calling ethtool during reload can lead to call trace, because VSI isn't configured for some time, but netdev is alive. To fix it add rtnl lock for VSI deconfig and config. Set ::num_q_vectors to 0 after freeing and add a check for ::tx/rx_rings in ring related ethtool ops. Add proper unroll of filters in ice_start_eth(). Reproduction: $watch -n 0.1 -d 'ethtool -g enp24s0f0np0' $devlink dev reload pci/0000:18:00.0 action driver_reinit Call trace before fix: [66303.926205] BUG: kernel NULL pointer dereference, address: 0000000000000000 [66303.926259] #PF: supervisor read access in kernel mode [66303.926286] #PF: error_code(0x0000) - not-present page [66303.926311] PGD 0 P4D 0 [66303.926332] Oops: 0000 [#1] PREEMPT SMP PTI [66303.926358] CPU: 4 PID: 933821 Comm: ethtool Kdump: loaded Tainted: G OE 6.4.0-rc5+ #1 [66303.926400] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.00.01.0014.070920180847 07/09/2018 [66303.926446] RIP: 0010:ice_get_ringparam+0x22/0x50 [ice] [66303.926649] Code: 90 90 90 90 90 90 90 90 f3 0f 1e fa 0f 1f 44 00 00 48 8b 87 c0 09 00 00 c7 46 04 e0 1f 00 00 c7 46 10 e0 1f 00 00 48 8b 50 20 <48> 8b 12 0f b7 52 3a 89 56 14 48 8b 40 28 48 8b 00 0f b7 40 58 48 [66303.926722] RSP: 0018:ffffad40472f39c8 EFLAGS: 00010246 [66303.926749] RAX: ffff98a8ada05828 RBX: ffff98a8c46dd060 RCX: ffffad40472f3b48 [66303.926781] RDX: 0000000000000000 RSI: ffff98a8c46dd068 RDI: ffff98a8b23c4000 [66303.926811] RBP: ffffad40472f3b48 R08: 00000000000337b0 R09: 0000000000000000 [66303.926843] R10: 0000000000000001 R11: 0000000000000100 R12: ffff98a8b23c4000 [66303.926874] R13: ffff98a8c46dd060 R14: 000000000000000f R15: ffffad40472f3a50 [66303.926906] FS: 00007f6397966740(0000) GS:ffff98b390900000(0000) knlGS:0000000000000000 [66303.926941] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [66303.926967] CR2: 0000000000000000 CR3: 000000011ac20002 CR4: 00000000007706e0 [66303.926999] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [66303.927029] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [66303.927060] PKRU: 55555554 [66303.927075] Call Trace: [66303.927094] <TASK> [66303.927111] ? __die+0x23/0x70 [66303.927140] ? page_fault_oops+0x171/0x4e0 [66303.927176] ? exc_page_fault+0x7f/0x180 [66303.927209] ? asm_exc_page_fault+0x26/0x30 [66303.927244] ? ice_get_ringparam+0x22/0x50 [ice] [66303.927433] rings_prepare_data+0x62/0x80 [66303.927469] ethnl_default_doit+0xe2/0x350 [66303.927501] genl_family_rcv_msg_doit.isra.0+0xe3/0x140 [66303.927538] genl_rcv_msg+0x1b1/0x2c0 [66303.927561] ? __pfx_ethnl_default_doit+0x10/0x10 [66303.927590] ? __pfx_genl_rcv_msg+0x10/0x10 [66303.927615] netlink_rcv_skb+0x58/0x110 [66303.927644] genl_rcv+0x28/0x40 [66303.927665] netlink_unicast+0x19e/0x290 [66303.927691] netlink_sendmsg+0x254/0x4d0 [66303.927717] sock_sendmsg+0x93/0xa0 [66303.927743] __sys_sendto+0x126/0x170 [66303.927780] __x64_sys_sendto+0x24/0x30 [66303.928593] do_syscall_64+0x5d/0x90 [66303.929370] ? __count_memcg_events+0x60/0xa0 [66303.930146] ? count_memcg_events.constprop.0+0x1a/0x30 [66303.930920] ? handle_mm_fault+0x9e/0x350 [66303.931688] ? do_user_addr_fault+0x258/0x740 [66303.932452] ? exc_page_fault+0x7f/0x180 [66303.933193] entry_SYSCALL_64_after_hwframe+0x72/0xdc Fixes: 5b246e533d ("ice: split probe into smaller functions") Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>		2023-07-14 09:56:20 -07:00
..
ice_adminq_cmd.h	ice: update ICE_PHY_TYPE_HIGH_MAX_INDEX	2023-05-17 08:38:22 -07:00
ice_arfs.c	ice: add individual interrupt allocation	2023-05-16 09:38:38 -07:00
ice_arfs.h
ice_base.c	ice: prevent NULL pointer deref during reload	2023-07-14 09:56:20 -07:00
ice_base.h
ice_cgu_regs.h
ice_common.c	ice: Remove managed memory usage in ice_get_fw_log_cfg()	2023-06-22 11:14:24 -07:00
ice_common.h	ice: make writes to /dev/gnssX synchronous	2023-06-07 10:51:58 +01:00
ice_controlq.c	ice: remove null checks before devm_kfree() calls	2023-06-22 10:30:34 -07:00
ice_controlq.h	ice: reduce initial wait for control queue messages	2023-06-22 10:23:44 -07:00
ice_dcb_lib.c	ice: Fix undersized tx_flags variable	2023-05-12 09:27:44 +01:00
ice_dcb_lib.h	ice: Prevent set_channel from changing queues while RDMA active	2023-01-27 11:32:18 -08:00
ice_dcb_nl.c
ice_dcb_nl.h
ice_dcb.c	ice: Fix DSCP PFC TLV creation	2023-03-07 13:02:01 -08:00
ice_dcb.h	ice: Handle LLDP MIB Pending change	2023-01-19 08:18:03 -08:00
ice_ddp.c	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_ddp.h	overflow: Add struct_size_t() helper	2023-05-26 13:52:19 -07:00
ice_devids.h	ice: support features on new E810T variants	2022-09-28 11:40:57 -07:00
ice_devlink.c	devlink: move port_split/unsplit() ops into devlink_port_ops	2023-05-30 10:32:20 -07:00
ice_devlink.h	ice: Prevent ADQ, DCB coexistence with Custom Tx scheduler	2022-11-17 21:41:28 -08:00
ice_eswitch.c	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_eswitch.h	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_ethtool_fdir.c
ice_ethtool.c	ice: prevent NULL pointer deref during reload	2023-07-14 09:56:20 -07:00
ice_ethtool.h	ice: update PHY type to ethtool link mode mapping	2023-05-17 08:43:01 -07:00
ice_fdir.c
ice_fdir.h
ice_flex_pipe.c	ice: Reduce scope of variables	2023-01-19 08:18:03 -08:00
ice_flex_pipe.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flex_type.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flow.c	ice: remove null checks before devm_kfree() calls	2023-06-22 10:30:34 -07:00
ice_flow.h
ice_fltr.c	ice: sync netdev filters after clearing VSI	2023-02-03 09:54:18 -08:00
ice_fltr.h
ice_fw_update.c
ice_fw_update.h
ice_gnss.c	ice: Don't dereference NULL in ice_gnss_read error path	2023-06-08 08:38:56 -07:00
ice_gnss.h	ice: make writes to /dev/gnssX synchronous	2023-06-07 10:51:58 +01:00
ice_hw_autogen.h	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_idc_int.h
ice_idc.c	ice: add dynamic interrupt allocation	2023-05-16 09:38:38 -07:00
ice_irq.c	ice: add dynamic interrupt allocation	2023-05-16 09:38:38 -07:00
ice_irq.h	ice: add dynamic interrupt allocation	2023-05-16 09:38:38 -07:00
ice_lag.c	ice: Remove LAG+SRIOV mutual exclusion	2023-05-17 08:43:47 -07:00
ice_lag.h	ice: Remove LAG+SRIOV mutual exclusion	2023-05-17 08:43:47 -07:00
ice_lan_tx_rx.h	ice: Remove and replace ice speed defines with ethtool.h versions	2022-11-23 08:59:42 -08:00
ice_lib.c	ice: Unregister netdev and devlink_port only once	2023-07-14 09:45:10 -07:00
ice_lib.h	ice: track interrupt vectors with xarray	2023-05-16 09:38:38 -07:00
ice_main.c	ice: prevent NULL pointer deref during reload	2023-07-14 09:56:20 -07:00
ice_nvm.c	ice: Remove cppcheck suppressions	2023-01-19 08:18:03 -08:00
ice_nvm.h	ice: Add additional flags to ice_nvm_write_activate	2022-08-24 08:45:54 -07:00
ice_osdep.h
ice_pf_vsi_vlan_ops.c
ice_pf_vsi_vlan_ops.h
ice_protocol_type.h	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_ptp_consts.h
ice_ptp_hw.c	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_ptp_hw.h	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_ptp.c	ice: introduce ICE_TX_TSTAMP_WORK enumeration	2023-06-08 10:20:12 -07:00
ice_ptp.h	ice: introduce ICE_TX_TSTAMP_WORK enumeration	2023-06-08 10:20:12 -07:00
ice_repr.c	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_repr.h	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_sbq_cmd.h
ice_sched.c	ice: remove null checks before devm_kfree() calls	2023-06-22 10:30:34 -07:00
ice_sched.h	ice: Add an option to pre-allocate memory for ice_sched_node	2022-11-17 21:41:28 -08:00
ice_sriov.c	ice: clean up freeing SR-IOV VFs	2023-06-22 10:29:31 -07:00
ice_sriov.h	ice: move ice_is_malicious_vf() to ice_virtchnl.c	2023-03-13 11:06:06 -07:00
ice_switch.c	ice: remove null checks before devm_kfree() calls	2023-06-22 10:30:34 -07:00
ice_switch.h	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_tc_lib.c	ice: Fix tx queue rate limit when TCs are configured	2023-07-05 09:29:37 -07:00
ice_tc_lib.h	ice: Fix tx queue rate limit when TCs are configured	2023-07-05 09:29:37 -07:00
ice_trace.h
ice_txrx_lib.c	ice: fix W=1 headers mismatch	2023-03-28 09:42:05 -07:00
ice_txrx_lib.h	ice: Micro-optimize .ndo_xdp_xmit() path	2023-02-13 19:13:13 +01:00
ice_txrx.c	ice: recycle/free all of the fragments from multi-buffer frame	2023-06-01 09:59:39 -07:00
ice_txrx.h	ice: Fix undersized tx_flags variable	2023-05-12 09:27:44 +01:00
ice_type.h	ice: move VF overflow message count into struct ice_mbx_vf_info	2023-03-13 10:32:32 -07:00
ice_vf_lib_private.h	ice: introduce ice_vf_init_host_cfg function	2023-02-06 09:41:56 -08:00
ice_vf_lib.c	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_vf_lib.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-05-18 14:39:34 -07:00
ice_vf_mbx.c	ice: merge ice_mbx_report_malvf with ice_mbx_vf_state_handler	2023-03-13 11:00:10 -07:00
ice_vf_mbx.h	ice: initialize mailbox snapshot earlier in PF init	2023-03-13 11:06:05 -07:00
ice_vf_vsi_vlan_ops.c	ice: Fix disabling Rx VLAN filtering with port VLAN enabled	2023-02-06 15:13:02 -08:00
ice_vf_vsi_vlan_ops.h
ice_virtchnl_allowlist.c	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_virtchnl_allowlist.h
ice_virtchnl_fdir.c	ice: Reset FDIR counter in FDIR init stage	2023-04-04 08:34:52 -07:00
ice_virtchnl_fdir.h
ice_virtchnl.c	ice: use src VSI instead of src MAC in slow-path	2023-05-19 09:10:39 -07:00
ice_virtchnl.h	ice: call ice_is_malicious_vf() from ice_vc_process_vf_msg()	2023-03-13 11:06:06 -07:00
ice_vlan_mode.c	ice: define meta data to match in switch	2023-05-19 08:57:43 -07:00
ice_vlan_mode.h
ice_vlan.h
ice_vsi_vlan_lib.c
ice_vsi_vlan_lib.h
ice_vsi_vlan_ops.c
ice_vsi_vlan_ops.h
ice_xsk.c	ice: add individual interrupt allocation	2023-05-16 09:38:38 -07:00
ice_xsk.h	ice: xsk: change batched Tx descriptor cleaning	2022-09-27 08:11:02 -07:00
ice.h	ice: handle extts in the miscellaneous interrupt thread	2023-06-08 10:06:40 -07:00
Makefile	ice: move interrupt related code to separate file	2023-05-16 09:16:53 -07:00