mirror_ubuntu-kernels/drivers/gpu/drm/amd
Nathan Chancellor 68c3bd9501 drm/amd/powerplay: Zero initialize freq in smu_v11_0_get_current_clk_freq
clang warns (trimmed for brevity):

drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1098:10: warning:
variable 'freq' is used uninitialized whenever '?:' condition is false
[-Wsometimes-uninitialized]
                ret =  smu_get_current_clk_freq_by_table(smu, clk_id, &freq);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If get_current_clk_freq_by_table is ever NULL, freq will fail to be
properly initialized. Zero initialize it to avoid using uninitialized
stack values.

smu_get_current_clk_freq_by_table expands to a ternary operator
conditional on smu->funcs->get_current_clk_freq_by_table being not NULL.
When this is false, freq will be uninitialized. Zero initialize freq to
avoid using random stack values if that ever happens.

Fixes: e36182490d ("drm/amd/powerplay: fix dpm freq unit error (10KHz -> Mhz)")
Link: https://github.com/ClangBuiltLinux/linux/issues/585
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-08 13:56:11 -05:00
..
acp treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
amdgpu drm/amdgpu/mes10.1: Fix header guard 2019-07-08 13:56:02 -05:00
amdkfd drm/amdkfd: Disable idle optimization for chained runlist 2019-07-03 14:32:10 -05:00
display drm/amdgpu: Use kmemdup rather than duplicating its implementation 2019-07-05 15:54:55 -05:00
include drm/amd/powerplay: make athub pg bit configured by pg_flags 2019-06-25 13:54:32 -05:00
powerplay drm/amd/powerplay: Zero initialize freq in smu_v11_0_get_current_clk_freq 2019-07-08 13:56:11 -05:00