Ding Hui a509702cac ice: Fix crash by keep old cfg when update TCs more than queues ... There are problems if allocated queues less than Traffic Classes. Commit a632b2a4c9 ("ice: ethtool: Prohibit improper channel config for DCB") already disallow setting less queues than TCs. Another case is if we first set less queues, and later update more TCs config due to LLDP, ice_vsi_cfg_tc() will failed but left dirty num_txq/rxq and tc_cfg in vsi, that will cause invalid pointer access. [ 95.968089] ice 0000:3b:00.1: More TCs defined than queues/rings allocated. [ 95.968092] ice 0000:3b:00.1: Trying to use more Rx queues (8), than were allocated (1)! [ 95.968093] ice 0000:3b:00.1: Failed to config TC for VSI index: 0 [ 95.969621] general protection fault: 0000 [#1] SMP NOPTI [ 95.969705] CPU: 1 PID: 58405 Comm: lldpad Kdump: loaded Tainted: G U W O --------- -t - 4.18.0 #1 [ 95.969867] Hardware name: O.E.M/BC11SPSCB10, BIOS 8.23 12/30/2021 [ 95.969992] RIP: 0010:devm_kmalloc+0xa/0x60 [ 95.970052] Code: 5c ff ff ff 31 c0 5b 5d 41 5c c3 b8 f4 ff ff ff eb f4 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 89 d1 <8b> 97 60 02 00 00 48 8d 7e 18 48 39 f7 72 3f 55 89 ce 53 48 8b 4c [ 95.970344] RSP: 0018:ffffc9003f553888 EFLAGS: 00010206 [ 95.970425] RAX: dead000000000200 RBX: ffffea003c425b00 RCX: 00000000006080c0 [ 95.970536] RDX: 00000000006080c0 RSI: 0000000000000200 RDI: dead000000000200 [ 95.970648] RBP: dead000000000200 R08: 00000000000463c0 R09: ffff888ffa900000 [ 95.970760] R10: 0000000000000000 R11: 0000000000000002 R12: ffff888ff6b40100 [ 95.970870] R13: ffff888ff6a55018 R14: 0000000000000000 R15: ffff888ff6a55460 [ 95.970981] FS: 00007f51b7d24700(0000) GS:ffff88903ee80000(0000) knlGS:0000000000000000 [ 95.971108] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 95.971197] CR2: 00007fac5410d710 CR3: 0000000f2c1de002 CR4: 00000000007606e0 [ 95.971309] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 95.971419] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 95.971530] PKRU: 55555554 [ 95.971573] Call Trace: [ 95.971622] ice_setup_rx_ring+0x39/0x110 [ice] [ 95.971695] ice_vsi_setup_rx_rings+0x54/0x90 [ice] [ 95.971774] ice_vsi_open+0x25/0x120 [ice] [ 95.971843] ice_open_internal+0xb8/0x1f0 [ice] [ 95.971919] ice_ena_vsi+0x4f/0xd0 [ice] [ 95.971987] ice_dcb_ena_dis_vsi.constprop.5+0x29/0x90 [ice] [ 95.972082] ice_pf_dcb_cfg+0x29a/0x380 [ice] [ 95.972154] ice_dcbnl_setets+0x174/0x1b0 [ice] [ 95.972220] dcbnl_ieee_set+0x89/0x230 [ 95.972279] ? dcbnl_ieee_del+0x150/0x150 [ 95.972341] dcb_doit+0x124/0x1b0 [ 95.972392] rtnetlink_rcv_msg+0x243/0x2f0 [ 95.972457] ? dcb_doit+0x14d/0x1b0 [ 95.972510] ? __kmalloc_node_track_caller+0x1d3/0x280 [ 95.972591] ? rtnl_calcit.isra.31+0x100/0x100 [ 95.972661] netlink_rcv_skb+0xcf/0xf0 [ 95.972720] netlink_unicast+0x16d/0x220 [ 95.972781] netlink_sendmsg+0x2ba/0x3a0 [ 95.975891] sock_sendmsg+0x4c/0x50 [ 95.979032] ___sys_sendmsg+0x2e4/0x300 [ 95.982147] ? kmem_cache_alloc+0x13e/0x190 [ 95.985242] ? __wake_up_common_lock+0x79/0x90 [ 95.988338] ? __check_object_size+0xac/0x1b0 [ 95.991440] ? _copy_to_user+0x22/0x30 [ 95.994539] ? move_addr_to_user+0xbb/0xd0 [ 95.997619] ? __sys_sendmsg+0x53/0x80 [ 96.000664] __sys_sendmsg+0x53/0x80 [ 96.003747] do_syscall_64+0x5b/0x1d0 [ 96.006862] entry_SYSCALL_64_after_hwframe+0x65/0xca Only update num_txq/rxq when passed check, and restore tc_cfg if setup queue map failed. Fixes: a632b2a4c9 ("ice: ethtool: Prohibit improper channel config for DCB") Signed-off-by: Ding Hui <dinghui@sangfor.com.cn> Reviewed-by: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com> Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>		2022-09-08 13:22:11 -07:00
..
ice_adminq_cmd.h	ice: add i2c write command	2022-07-21 11:22:45 -07:00
ice_arfs.c	ice: arfs: fix use-after-free when freeing @rx_cpu_rmap	2022-04-08 09:08:36 -07:00
ice_arfs.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_base.c	ice: Fix DMA mappings leak	2022-09-02 08:25:15 -07:00
ice_base.h
ice_cgu_regs.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_common.c	ice: add i2c write command	2022-07-21 11:22:45 -07:00
ice_common.h	ice: add i2c write command	2022-07-21 11:22:45 -07:00
ice_controlq.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_controlq.h
ice_dcb_lib.c	ice: Add hot path support for 802.1Q and 802.1ad VLAN offloads	2022-02-09 09:24:45 -08:00
ice_dcb_lib.h	ice: Add infrastructure for mqprio support via ndo_setup_tc	2021-10-20 15:57:54 -07:00
ice_dcb_nl.c	ice: Fix problems with DSCP QoS implementation	2021-12-07 13:21:01 -08:00
ice_dcb_nl.h
ice_dcb.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_dcb.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_devids.h	ice: handle E822 generic device ID in PLDM header	2022-07-12 09:25:34 -07:00
ice_devlink.c	ice: change devlink code to read NVM in blocks	2022-07-12 09:25:47 -07:00
ice_devlink.h	net/ice: Remove unused enum	2021-11-30 08:02:12 -08:00
ice_eswitch.c	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_eswitch.h	ice: allow creating VFs for !CONFIG_NET_SWITCHDEV	2022-04-14 08:19:54 -07:00
ice_ethtool_fdir.c	ice: Use correct order for the parameters of devm_kcalloc()	2022-06-08 08:55:13 -07:00
ice_ethtool.c	Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue	2022-07-29 21:26:10 -07:00
ice_fdir.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_fdir.h	ice: Add flow director support for channel mode	2021-12-30 13:16:07 +00:00
ice_flex_pipe.c	ice: Add support for PPPoE hardware offload	2022-07-26 10:56:32 -07:00
ice_flex_pipe.h	ice: Fix FV offset searching	2022-03-11 08:28:27 -08:00
ice_flex_type.h	ice: Support GTP-U and GTP-C offload in switchdev	2022-03-11 08:28:28 -08:00
ice_flow.c	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_flow.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_fltr.c	ice: Ignore error message when setting same promiscuous mode	2022-08-17 09:30:44 -07:00
ice_fltr.h	ice: Introduce ice_vlan struct	2022-02-09 09:24:45 -08:00
ice_fw_update.c	ice: handle E822 generic device ID in PLDM header	2022-07-12 09:25:34 -07:00
ice_fw_update.h	ice: support immediate firmware activation via devlink reload	2021-12-15 08:40:38 -08:00
ice_gnss.c	ice: add write functionality for GNSS TTY	2022-07-21 13:25:17 -07:00
ice_gnss.h	ice: add write functionality for GNSS TTY	2022-07-21 13:25:17 -07:00
ice_hw_autogen.h	ice: support crosstimestamping on E822 devices if supported	2021-12-21 09:11:40 -08:00
ice_idc_int.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_idc.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-05-12 16:15:30 -07:00
ice_lag.c	ice: Remove unnecessary NULL check before dev_put	2022-06-30 13:53:33 -07:00
ice_lag.h
ice_lan_tx_rx.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-02-10 17:29:56 -08:00
ice_lib.c	ice: Fix crash by keep old cfg when update TCs more than queues	2022-09-08 13:22:11 -07:00
ice_lib.h	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_main.c	ice: Don't double unplug aux on peer initiated reset	2022-09-08 11:21:41 -07:00
ice_nvm.c	ice: Fix memory leak in ice_get_orom_civd_data()	2022-04-14 08:31:01 -07:00
ice_nvm.h	ice: support immediate firmware activation via devlink reload	2021-12-15 08:40:38 -08:00
ice_osdep.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_pf_vsi_vlan_ops.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_pf_vsi_vlan_ops.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_protocol_type.h	ice: Add support for PPPoE hardware offload	2022-07-26 10:56:32 -07:00
ice_ptp_consts.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_ptp_hw.c	ice: add TTY for GNSS module for E810T device	2022-03-03 14:11:00 +00:00
ice_ptp_hw.h	ice: add TTY for GNSS module for E810T device	2022-03-03 14:11:00 +00:00
ice_ptp.c	ice: implement adjfine with mul_u64_u64_div_u64	2022-07-28 10:54:47 -07:00
ice_ptp.h	ice: Fix PTP TX timestamp offset calculation	2022-06-14 09:35:57 -07:00
ice_repr.c	ice: link representors to PCI device	2022-05-06 09:43:01 -07:00
ice_repr.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_sbq_cmd.h
ice_sched.c	ice: Remove unnecessary casts	2021-12-14 10:19:14 -08:00
ice_sched.h	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_sriov.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-07-28 18:21:16 -07:00
ice_sriov.h	ice: introduce ice_virtchnl.c and ice_virtchnl.h	2022-03-15 13:23:10 -07:00
ice_switch.c	ice: Ignore EEXIST when setting promisc mode	2022-08-17 09:30:23 -07:00
ice_switch.h	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_tc_lib.c	ice: Add support for PPPoE hardware offload	2022-07-26 10:56:32 -07:00
ice_tc_lib.h	ice: Add support for PPPoE hardware offload	2022-07-26 10:56:32 -07:00
ice_trace.h	ice: add trace events for tx timestamps	2022-03-16 10:38:15 -07:00
ice_txrx_lib.c	Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue	2022-02-10 11:00:13 +00:00
ice_txrx_lib.h	ice: Add hot path support for 802.1Q and 802.1ad VLAN offloads	2022-02-09 09:24:45 -08:00
ice_txrx.c	ice: Fix tunnel checksum offload with fragmented traffic	2022-07-26 13:15:36 -07:00
ice_txrx.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-05-19 11:23:59 -07:00
ice_type.h	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_vf_lib_private.h	ice: remove PF pointer from ice_check_vf_init	2022-03-15 13:23:14 -07:00
ice_vf_lib.c	ice: Fix VF not able to send tagged traffic with no VLAN filters	2022-08-17 09:30:44 -07:00
ice_vf_lib.h	ice: Fix promiscuous mode not turning off	2022-07-28 11:44:40 -07:00
ice_vf_mbx.c	ice: rename ice_sriov.c to ice_vf_mbx.c	2022-03-14 17:22:58 -07:00
ice_vf_mbx.h	ice: rename ice_sriov.c to ice_vf_mbx.c	2022-03-14 17:22:58 -07:00
ice_vf_vsi_vlan_ops.c	ice: rename ice_virtchnl_pf.c to ice_sriov.c	2022-03-14 17:22:58 -07:00
ice_vf_vsi_vlan_ops.h	ice: Add support for VIRTCHNL_VF_OFFLOAD_VLAN_V2	2022-02-09 09:24:45 -08:00
ice_virtchnl_allowlist.c	ice: Add support for VIRTCHNL_VF_OFFLOAD_VLAN_V2	2022-02-09 09:24:45 -08:00
ice_virtchnl_allowlist.h
ice_virtchnl_fdir.c	ice: always check VF VSI pointer values	2022-05-05 11:28:36 -07:00
ice_virtchnl_fdir.h	ice: introduce ice_vf_lib.c, ice_vf_lib.h, and ice_vf_lib_private.h	2022-03-15 13:22:13 -07:00
ice_virtchnl.c	ice: Fix VF not able to send tagged traffic with no VLAN filters	2022-08-17 09:30:44 -07:00
ice_virtchnl.h	ice: introduce ice_virtchnl.c and ice_virtchnl.h	2022-03-15 13:23:10 -07:00
ice_vlan_mode.c	ice: Add support for VLAN TPID filters in switchdev	2022-06-30 13:53:33 -07:00
ice_vlan_mode.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vlan.h	ice: Use the proto argument for VLAN ops	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.c	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_xsk.c	ice: Fix DMA mappings leak	2022-09-02 08:25:15 -07:00
ice_xsk.h	ice: Fix DMA mappings leak	2022-09-02 08:25:15 -07:00
ice.h	ice: xsk: use Rx ring's XDP ring when picking NAPI context	2022-08-22 08:47:26 -07:00
Makefile	ice: fix access-beyond-end in the switch code	2022-06-02 12:41:10 +02:00