Ciara Loftus 5bec7ca2be xsk: Initialise xskb free_list_node ... This commit initialises the xskb's free_list_node when the xskb is allocated. This prevents a potential false negative returned from a call to list_empty for that node, such as the one introduced in commit 199d983bc0 ("xsk: Fix crash on double free in buffer pool") In my environment this issue caused packets to not be received by the xdpsock application if the traffic was running prior to application launch. This happened when the first batch of packets failed the xskmap lookup and XDP_PASS was returned from the bpf program. This action is handled in the i40e zc driver (and others) by allocating an skbuff, freeing the xdp_buff and adding the associated xskb to the xsk_buff_pool's free_list if it hadn't been added already. Without this fix, the xskb is not added to the free_list because the check to determine if it was added already returns an invalid positive result. Later, this caused allocation errors in the driver and the failure to receive packets. Fixes: 199d983bc0 ("xsk: Fix crash on double free in buffer pool") Fixes: 2b43470add ("xsk: Introduce AF_XDP buffer allocation API") Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> Acked-by: Magnus Karlsson <magnus.karlsson@intel.com> Link: https://lore.kernel.org/r/20211220155250.2746-1-ciara.loftus@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2021-12-29 10:00:18 -08:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	xsk: Introduce AF_XDP buffer allocation API	2020-05-21 17:31:26 -07:00
xdp_umem.c	xsk: Use kvcalloc to support large umems	2021-05-25 13:11:50 +02:00
xdp_umem.h	xsk: Fix umem cleanup bug at socket destruct	2020-11-20 15:52:39 +01:00
xsk_buff_pool.c	xsk: Initialise xskb free_list_node	2021-12-29 10:00:18 -08:00
xsk_diag.c	xsk: Fix possible segfault in xsk umem diagnostics	2020-09-02 16:49:40 +02:00
xsk_queue.c	xsk: Remove MEM_TYPE_ZERO_COPY and corresponding code	2020-05-21 17:31:27 -07:00
xsk_queue.h	xsk: Batched buffer allocation for the pool	2021-09-28 00:18:34 +02:00
xsk.c	xsk: Do not sleep in poll() when need_wakeup set	2021-12-14 15:20:54 +01:00
xsk.h	xdp: Add proper __rcu annotations to redirect map entries	2021-06-24 19:41:15 +02:00
xskmap.c	xdp: Add proper __rcu annotations to redirect map entries	2021-06-24 19:41:15 +02:00