mirror_ubuntu-kernels/drivers/platform/x86/intel
David Arcari 3279decb2c platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain
Object Debug results in the following warning while attempting to load
ifs firmware:

[  220.007422] ODEBUG: object 000000003bf952db is on stack 00000000e843994b, but NOT annotated.
[  220.007459] ------------[ cut here ]------------
[  220.007461] WARNING: CPU: 0 PID: 11774 at lib/debugobjects.c:548 __debug_object_init.cold+0x22e/0x2d5
[  220.137476] RIP: 0010:__debug_object_init.cold+0x22e/0x2d5
[  220.254774] Call Trace:
[  220.257641]  <TASK>
[  220.265606]  scan_chunks_sanity_check+0x368/0x5f0 [intel_ifs]
[  220.288292]  ifs_load_firmware+0x2a3/0x400 [intel_ifs]
[  220.332793]  current_batch_store+0xea/0x160 [intel_ifs]
[  220.357947]  kernfs_fop_write_iter+0x355/0x530
[  220.363048]  new_sync_write+0x28e/0x4a0
[  220.381226]  vfs_write+0x62a/0x920
[  220.385160]  ksys_write+0xf9/0x1d0
[  220.399421]  do_syscall_64+0x59/0x90
[  220.440635]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
[  220.566845] ---[ end trace 3a01b299db142b41 ]---

Correct this by calling INIT_WORK_ONSTACK instead of INIT_WORK.

Fixes: 684ec21570 ("platform/x86/intel/ifs: Authenticate and copy to secured memory")

Signed-off-by: David Arcari <darcari@redhat.com>
Cc: Jithu Joseph <jithu.joseph@intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230523105400.674152-1-darcari@redhat.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2023-05-23 12:55:16 +02:00
..
atomisp2 platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF 2022-07-10 19:37:19 +02:00
ifs platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain 2023-05-23 12:55:16 +02:00
int1092 platform/x86: intel: int1092: intel_sar: Convert to platform remove callback returning void 2023-03-07 12:20:31 +01:00
int3472 platform/x86: intel: int3472: discrete: Convert to platform remove callback returning void 2023-03-07 12:20:33 +01:00
pmc Power management updates for 6.4-rc1 2023-04-25 18:44:10 -07:00
pmt Driver core changes for 6.4-rc1 2023-04-27 11:53:57 -07:00
speed_select_if platform/x86: ISST: Remove 8 socket limit 2023-05-23 12:52:05 +02:00
telemetry platform/x86: intel: telemetry: pltdrv: Convert to platform remove callback returning void 2023-03-07 12:20:40 +01:00
uncore-frequency platform/x86/intel-uncore-freq: Return error on write frequency 2023-05-09 10:53:58 +02:00
wmi platform/x86/intel/wmi: thunderbolt: Use dev_groups callback 2022-09-27 16:01:44 +02:00
bxtwc_tmu.c platform/x86: intel: bxtwc_tmu: Convert to platform remove callback returning void 2023-03-07 12:20:21 +01:00
bytcrc_pwrsrc.c platform/x86: Add intel_bytcrc_pwrsrc driver 2023-03-16 14:42:30 +01:00
chtdc_ti_pwrbtn.c platform/x86: intel: chtdc_ti_pwrbtn: Convert to platform remove callback returning void 2023-03-07 12:20:23 +01:00
chtwc_int33fe.c platform/x86: intel: chtwc_int33fe: Convert to platform remove callback returning void 2023-03-07 12:20:25 +01:00
crystal_cove_charger.c platform/x86: intel_crystal_cove_charger: Fix IRQ masking / unmasking 2022-01-24 10:41:46 +01:00
hid.c platform/x86: intel: hid: Convert to platform remove callback returning void 2023-03-07 12:20:27 +01:00
int0002_vgpio.c platform/x86: intel: int0002_vgpio: Convert to platform remove callback returning void 2023-03-07 12:20:29 +01:00
ishtp_eclite.c HID: intel-ish-hid: fix module device-id handling 2021-11-11 22:45:40 +01:00
Kconfig platform/x86: Add intel_bytcrc_pwrsrc driver 2023-03-16 14:42:30 +01:00
Makefile platform/x86: Add intel_bytcrc_pwrsrc driver 2023-03-16 14:42:30 +01:00
mrfld_pwrbtn.c platform/x86: intel: mrfld_pwrbtn: Convert to platform remove callback returning void 2023-03-07 12:20:35 +01:00
oaktrail.c platform/x86: intel: oaktrail: Drop empty platform remove function 2023-02-02 22:48:20 +01:00
punit_ipc.c platform/x86: intel: punit_ipc: Drop empty platform remove function 2023-02-02 22:48:20 +01:00
rst.c ACPI: make remove callback of ACPI driver void 2022-11-23 19:11:22 +01:00
sdsi.c platform/x86/intel/sdsi: Change mailbox timeout 2023-04-17 12:12:29 +02:00
smartconnect.c platform/x86: intel-smartconnect: Move to intel sub-directory 2021-08-20 20:11:12 +02:00
tpmi.c platform/x86/intel: tpmi: Revise the comment of intel_vsec_add_aux 2023-03-20 13:11:55 +01:00
turbo_max_3.c platform/x86: intel_turbo_max_3: Move to intel sub-directory 2021-08-20 20:11:22 +02:00
vbtn.c platform/x86: intel: vbtn: Convert to platform remove callback returning void 2023-03-07 12:20:41 +01:00
vsec.c platform-drivers-x86 for v6.4-1 2023-04-25 16:59:48 -07:00
vsec.h platform/x86/intel: vsec: Explicitly enable capabilities 2023-03-20 14:44:27 +01:00