Paolo Abeni b6c620dc43 mptcp: fix data re-injection from stale subflow ... When the MPTCP PM detects that a subflow is stale, all the packet scheduler must re-inject all the mptcp-level unacked data. To avoid acquiring unneeded locks, it first try to check if any unacked data is present at all in the RTX queue, but such check is currently broken, as it uses TCP-specific helper on an MPTCP socket. Funnily enough fuzzers and static checkers are happy, as the accessed memory still belongs to the mptcp_sock struct, and even from a functional perspective the recovery completed successfully, as the short-cut test always failed. A recent unrelated TCP change - commit d5fed5addb ("tcp: reorganize tcp_sock fast path variables") - exposed the issue, as the tcp field reorganization makes the mptcp code always skip the re-inection. Fix the issue dropping the bogus call: we are on a slow path, the early optimization proved once again to be evil. Fixes: 1e1d9d6f11 ("mptcp: handle pending data on closed subflow") Cc: stable@vger.kernel.org Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/468 Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://lore.kernel.org/r/20240131-upstream-net-20240131-mptcp-ci-issues-v1-1-4c1c11e571ff@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-02-01 09:06:37 -08:00
..
6lowpan
9p	net: 9p: avoid freeing uninit memory in p9pdu_vreadf	2023-12-13 05:44:30 +09:00
802	net: fill in MODULE_DESCRIPTION()s under net/802*	2023-10-28 11:29:28 +01:00
8021q	vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING	2024-01-19 21:25:06 -08:00
appletalk	net: remove SOCK_DEBUG leftovers	2023-12-26 20:31:01 +00:00
atm	net: fill in MODULE_DESCRIPTION()s for ATM	2024-01-05 08:04:23 -08:00
ax25	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
batman-adv	batman-adv: Switch to linux/array_size.h	2023-11-14 08:16:34 +01:00
bluetooth	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
bpf	bpf: Fix dtor CFI	2023-12-15 16:25:55 -08:00
bridge	bridge: mcast: fix disabled snooping after long uptime	2024-01-30 18:06:56 -08:00
caif	net: fill in MODULE_DESCRIPTION()s for CAIF	2024-01-05 08:06:35 -08:00
can	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-12 17:07:34 -07:00
ceph	libceph: remove MAX_EXTENTS check for sparse reads	2024-01-15 15:40:50 +01:00
core	xdp: reflect tail increase for MEM_TYPE_XSK_BUFF_POOL	2024-01-24 16:24:07 -08:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-01 21:07:46 -07:00
dccp	net: remove SOCK_DEBUG leftovers	2023-12-26 20:31:01 +00:00
devlink	devlink: Fix referring to hw_addr attribute during state validation	2024-01-30 18:32:41 -08:00
dns_resolver	Networking changes for 6.8.	2024-01-11 10:07:29 -08:00
dsa	net: dsa: fix netdev_priv() dereference before check on non-DSA netdevice events	2024-01-11 16:33:52 -08:00
ethernet
ethtool	ethtool: netlink: Add missing ethnl_ops_begin/complete	2024-01-18 13:21:06 +01:00
handshake	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-26 13:46:28 -07:00
hsr	net: hsr: remove WARN_ONCE() in send_hsr_supervision_frame()	2024-01-29 11:29:55 +00:00
ieee802154	mac802154: Avoid new associations while disassociating	2023-12-15 11:14:57 +01:00
ife	net: sched: ife: fix potential use-after-free	2023-12-15 10:50:18 +00:00
ipv4	net: ipv4: fix a memleak in ip_setup_cork	2024-01-31 15:53:25 -08:00
ipv6	ipv6: Ensure natural alignment of const ipv6 loopback and router addresses	2024-01-30 12:43:18 +01:00
iucv	iucv: make iucv_bus const	2023-12-29 07:46:38 +00:00
kcm	net: kcm: fix direct access to bv_len	2024-01-03 18:37:22 -08:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
l2tp	ipv6: annotate data-races around np->ucast_oif	2023-12-11 10:59:17 +00:00
l3mdev
lapb
llc	llc: call sock_orphan() at release time	2024-01-30 13:49:09 +01:00
mac80211	wireless fixes for v6.8-rc2	2024-01-23 08:38:13 -08:00
mac802154	mac802154: Avoid new associations while disassociating	2023-12-15 11:14:57 +01:00
mctp	mctp: perform route lookups under a RCU read-side lock	2023-10-10 19:43:22 -07:00
mpls	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
mptcp	mptcp: fix data re-injection from stale subflow	2024-02-01 09:06:37 -08:00
ncsi	net/ncsi: Add NC-SI 1.2 Get MC MAC Address command	2023-11-18 15:00:51 +00:00
netfilter	netfilter: nf_tables: validate NFPROTO_* family	2024-01-24 20:02:40 +01:00
netlabel	calipso: fix memory leak in netlbl_calipso_add_pass()	2023-12-07 14:23:12 -05:00
netlink	netlink: fix potential sleeping issue in mqueue_flush_file	2024-01-23 11:21:18 +01:00
netrom	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
nfc	nfc: nci: free rx_data_reassembly skb on NCI device cleanup	2024-01-29 12:05:31 +00:00
nsh
openvswitch	net/sched: act_ct: Always fill offloading tuple iifidx	2023-11-08 17:47:08 -08:00
packet	net: fill in MODULE_DESCRIPTION() for AF_PACKET	2024-01-05 08:06:35 -08:00
phonet
psample	genetlink: Use internal flags for multicast groups	2023-12-29 08:43:59 +00:00
qrtr	net: qrtr: ns: Return 0 if server port is not present	2024-01-01 18:41:29 +00:00
rds	net/rds: Fix UBSAN: array-index-out-of-bounds in rds_cmsg_recv	2024-01-22 11:24:00 +00:00
rfkill	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-12-21 22:17:23 +01:00
rose	net/rose: fix races in rose_kill_by_device()	2023-12-15 11:59:53 +00:00
rxrpc	rxrpc: Fix use of Don't Fragment flag	2024-01-11 16:41:41 -08:00
sched	net/sched: flower: Fix chain template offload	2024-01-24 01:33:59 +00:00
sctp	sctp: fix busy polling	2024-01-04 10:29:18 +00:00
smc	net/smc: fix incorrect SMC-D link group matching logic	2024-01-26 14:06:05 -08:00
strparser
sunrpc	nfsd-6.8 fixes:	2024-01-25 10:26:52 -08:00
switchdev	net: switchdev: Add a helper to replay objects on a bridge port	2023-07-21 08:54:03 +01:00
tipc	tipc: Remove some excess struct member documentation	2023-12-22 23:14:43 +00:00
tls	net: tls, fix WARNIING in __sk_msg_free	2024-01-14 12:17:14 +00:00
unix	af_unix: fix lockdep positive in sk_diag_dump_icons()	2024-01-31 17:51:55 -08:00
vmw_vsock	vsock/virtio: use skb_frag_*() helpers	2024-01-03 18:37:16 -08:00
wireless	wireless fixes for v6.8-rc2	2024-01-23 08:38:13 -08:00
x25	net: remove SOCK_DEBUG leftovers	2023-12-26 20:31:01 +00:00
xdp	xsk: make xsk_buff_pool responsible for clearing xdp_buff::flags	2024-01-24 16:24:06 -08:00
xfrm	bpf: xfrm: Add bpf_xdp_get_xfrm_state() kfunc	2023-12-14 17:12:49 -08:00
compat.c	file: stop exposing receive_fd_user()	2023-12-12 14:24:14 +01:00
devres.c
Kconfig	bpfilter: remove bpfilter	2024-01-04 10:23:10 -08:00
Kconfig.debug
Makefile	bpfilter: remove bpfilter	2024-01-04 10:23:10 -08:00
socket.c	vfs-6.8.iov_iter	2024-01-08 11:43:04 -08:00
sysctl_net.c	sysctl: Add size to register_net_sysctl function	2023-08-15 15:26:17 -07:00