mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2026-01-23 12:03:26 +00:00
fd7ef879a9
When built with Control Flow Integrity, function prototypes between
caller and function declaration must match. These mismatches are visible
at compile time with the new -Wcast-function-type-strict in Clang[1].
Fix a total of 42 warnings like these:
../drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3868:2: warning: cast from 'int (*)(struct net_device *, struct iw_request_info *, char *, char *)' to 'iw_handler' (aka 'int (*)(struct net_device *, struct iw_request_info *, union iwreq_data *, char *)') converts to incompatible function type [-Wcast-function-type-strict]
(iw_handler) prism2_get_name, /* SIOCGIWNAME */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
The hostap Wireless Extension handler callbacks (iw_handler) use a
union for the data argument. Actually use the union and perform explicit
member selection in the function body instead of having a function
prototype mismatch. There are no resulting binary differences
before/after changes.
These changes were made partly manually and partly with the help of
Coccinelle.
Link: https://github.com/KSPP/linux/issues/235
Link: https://reviews.llvm.org/D134831 [1]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/e480e7713f1a4909ae011068c8d793cc4a638fbd.1667934775.git.gustavoars@kernel.org
|
||
|---|---|---|
| .. | ||
| hostap_80211_rx.c | ||
| hostap_80211_tx.c | ||
| hostap_80211.h | ||
| hostap_ap.c | ||
| hostap_ap.h | ||
| hostap_common.h | ||
| hostap_config.h | ||
| hostap_cs.c | ||
| hostap_download.c | ||
| hostap_hw.c | ||
| hostap_info.c | ||
| hostap_ioctl.c | ||
| hostap_main.c | ||
| hostap_pci.c | ||
| hostap_plx.c | ||
| hostap_proc.c | ||
| hostap_wlan.h | ||
| hostap.h | ||
| Kconfig | ||
| Makefile | ||