mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2026-01-03 11:56:32 +00:00
5b361328ca
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| i40iw_cm.c | ||
| i40iw_cm.h | ||
| i40iw_ctrl.c | ||
| i40iw_d.h | ||
| i40iw_hmc.c | ||
| i40iw_hmc.h | ||
| i40iw_hw.c | ||
| i40iw_main.c | ||
| i40iw_osdep.h | ||
| i40iw_p.h | ||
| i40iw_pble.c | ||
| i40iw_pble.h | ||
| i40iw_puda.c | ||
| i40iw_puda.h | ||
| i40iw_register.h | ||
| i40iw_status.h | ||
| i40iw_type.h | ||
| i40iw_uk.c | ||
| i40iw_user.h | ||
| i40iw_utils.c | ||
| i40iw_verbs.c | ||
| i40iw_verbs.h | ||
| i40iw_vf.c | ||
| i40iw_vf.h | ||
| i40iw_virtchnl.c | ||
| i40iw_virtchnl.h | ||
| i40iw.h | ||
| Kconfig | ||
| Makefile | ||