mirror_ubuntu-kernels/tools/testing/selftests/net/mptcp
Matthieu Baerts 0fcd72df88 selftests: mptcp: join: fix ShellCheck warnings
Most of the code had an issue according to ShellCheck.

That's mainly due to the fact it incorrectly believes most of the code
was unreachable because it's invoked by variable name, see how the
"tests" array is used.

Once SC2317 has been ignored, three small warnings were still visible:

 - SC2155: Declare and assign separately to avoid masking return values.

 - SC2046: Quote this to prevent word splitting: can be ignored because
   "ip netns pids" can display more than one pid.

 - SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.

This probably didn't fix any actual issues but it might help spotting
new interesting warnings reported by ShellCheck as just before,
ShellCheck was reporting issues for most lines making it a bit useless.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-04-17 08:25:33 +01:00
..
.gitignore selftests: mptcp: add inq test case 2021-12-07 11:36:30 -08:00
config selftests: mptcp: add infinite map testcase 2022-04-27 10:45:53 +01:00
diag.sh selftest: mptcp: add test for mptcp socket in use 2023-01-09 07:30:50 +00:00
Makefile linux-kselftest-next-5.20-rc1 2022-08-02 19:44:56 -07:00
mptcp_connect.c selftests: mptcp: remove duplicated entries in usage 2023-04-17 08:25:33 +01:00
mptcp_connect.sh selftests: mptcp: uniform 'rndh' variable 2022-12-01 20:06:06 -08:00
mptcp_inq.c selftests: mptcp: Initialize variables to quiet gcc 12 warnings 2022-06-28 20:45:43 -07:00
mptcp_join.sh selftests: mptcp: join: fix ShellCheck warnings 2023-04-17 08:25:33 +01:00
mptcp_sockopt.c selftests: mptcp: Initialize variables to quiet gcc 12 warnings 2022-06-28 20:45:43 -07:00
mptcp_sockopt.sh selftests: mptcp: declare var as local 2022-12-01 20:06:06 -08:00
pm_netlink.sh selftests: mptcp: add set_flags tests in pm_netlink.sh 2022-02-04 20:30:24 -08:00
pm_nl_ctl.c selftests: mptcp: update pm_nl_ctl usage header 2022-07-09 12:19:24 +01:00
settings selftests: mptcp: increase timeout to 20 minutes 2022-02-17 19:59:58 -08:00
simult_flows.sh selftests: mptcp: uniform 'rndh' variable 2022-12-01 20:06:06 -08:00
userspace_pm.sh selftests: mptcp: userspace pm: uniform verify events 2023-04-13 09:58:55 -07:00