mirror_ubuntu-kernels/drivers/net/wireless/intel
Johannes Berg 1a528ab1da wifi: iwlwifi: mvm: avoid baid size integer overflow
Roee reported various hard-to-debug crashes with pings in
EHT aggregation scenarios. Enabling KASAN showed that we
access the BAID allocation out of bounds, and looking at
the code a bit shows that since the reorder buffer entry
(struct iwl_mvm_reorder_buf_entry) is 128 bytes if debug
such as lockdep is enabled, then staring from an agg size
512 we overflow the size calculation, and allocate a much
smaller structure than we should, causing slab corruption
once we initialize this.

Fix this by simply using u32 instead of u16.

Reported-by: Roee Goldfiner <roee.h.goldfiner@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230620125813.f428c856030d.I2c2bb808e945adb71bc15f5b2bac2d8957ea90eb@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2023-06-21 14:02:16 +02:00
..
ipw2x00 wifi: ipw2x00: remove unused _ipw_read16 function 2023-03-31 17:43:55 +03:00
iwlegacy wifi: iwlegacy: avoid fortify warning 2023-02-17 11:35:54 +02:00
iwlwifi wifi: iwlwifi: mvm: avoid baid size integer overflow 2023-06-21 14:02:16 +02:00
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile iwlwifi: fix build error for IWLMEI 2022-03-02 22:36:49 +01:00