Eric Dumazet b9fb10d131 l2tp: prevent lockdep issue in l2tp_tunnel_register() ... lockdep complains with the following lock/unlock sequence: lock_sock(sk); write_lock_bh(&sk->sk_callback_lock); [1] release_sock(sk); [2] write_unlock_bh(&sk->sk_callback_lock); We need to swap [1] and [2] to fix this issue. Fixes: 0b2c59720e ("l2tp: close all race conditions in l2tp_tunnel_register()") Reported-by: syzbot+bbd35b345c7cab0d9a08@syzkaller.appspotmail.com Signed-off-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/netdev/20230114030137.672706-1-xiyou.wangcong@gmail.com/T/#m1164ff20628671b0f326a24cb106ab3239c70ce3 Cc: Cong Wang <cong.wang@bytedance.com> Cc: Guillaume Nault <gnault@redhat.com> Reviewed-by: Guillaume Nault <gnault@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-01-18 14:44:54 +00:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
l2tp_core.c	l2tp: prevent lockdep issue in l2tp_tunnel_register()	2023-01-18 14:44:54 +00:00
l2tp_core.h	net/l2tp: convert tunnel rwlock_t to rcu	2021-11-29 12:11:25 +00:00
l2tp_debugfs.c	l2tp: l2tp_debugfs: fix Clang -Wformat warnings	2022-07-08 12:14:36 +01:00
l2tp_eth.c	l2tp: move from strlcpy with unused retval to strscpy	2022-08-22 17:59:46 -07:00
l2tp_ip6.c	inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().	2022-10-24 09:40:38 +01:00
l2tp_ip.c	l2tp: use add READ_ONCE() to fetch sk->sk_bound_dev_if	2022-05-16 10:31:06 +01:00
l2tp_netlink.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
l2tp_ppp.c	net: l2tp: fix clang -Wformat warning	2022-07-07 18:07:01 -07:00
Makefile	l2tp: add tracepoint infrastructure to core	2020-08-22 12:44:37 -07:00
trace.h	l2tp: add tracepoint definitions in trace.h	2020-08-22 12:44:37 -07:00