mirror_ubuntu-kernels/tools/testing
Tony Ambardar 03bfcda1fb selftests/bpf: Fix arg parsing in veristat, test_progs
Current code parses arguments with strtok_r() using a construct like

    char *state = NULL;
    while ((next = strtok_r(state ? NULL : input, ",", &state))) {
        ...
    }

where logic assumes the 'state' var can distinguish between first and
subsequent strtok_r() calls, and adjusts parameters accordingly. However,
'state' is strictly internal context for strtok_r() and no such assumptions
are supported in the man page. Moreover, the exact behaviour of 'state'
depends on the libc implementation, making the above code fragile.

Indeed, invoking "./test_progs -t <test_name>" on mips64el/musl will hang,
with the above code in an infinite loop.

Similarly, we see strange behaviour running 'veristat' on mips64el/musl:

    $ ./veristat -e file,prog,verdict,insns -C two-ok add-failure
    Can't specify more than 9 stats

Rewrite code using a counter to distinguish between strtok_r() calls.

Fixes: 61ddff373f ("selftests/bpf: Improve by-name subtest selection logic in prog_tests")
Fixes: 394169b079 ("selftests/bpf: add comparison mode to veristat")
Fixes: c8bc5e0509 ("selftests/bpf: Add veristat tool for mass-verifying BPF object files")
Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/392d8bf5559f85fa37926c1494e62312ef252c3d.1722244708.git.tony.ambardar@gmail.com
2024-07-30 13:45:44 -07:00
..
crypto/chacha20-s390
cxl cxl/region: check interleave capability 2024-06-25 14:45:27 -07:00
fault-injection
ktest
kunit RISC-V SoC Kconfig Updates for v6.10 2024-05-07 11:02:56 +02:00
memblock memblock tests: add memblock_overlaps_region_checks 2024-06-05 10:22:22 +03:00
nvdimm testing: nvdimm: Add MODULE_DESCRIPTION() macros 2024-06-17 18:43:08 -05:00
radix-tree tools/testing/radix-tree/idr-test: add missing MODULE_DESCRIPTION define 2024-06-28 19:36:27 -07:00
scatterlist
selftests selftests/bpf: Fix arg parsing in veristat, test_progs 2024-07-30 13:45:44 -07:00
vsock test/vsock: add install target 2024-07-13 15:17:35 -07:00