mirror_ubuntu-kernels/drivers/net/wireless/intersil/hostap
Sebastian Andrzej Siewior 75fd296398 net: hostap: Remove in_interrupt() usage
in_interrupt() is ill defined and does not provide what the name
suggests. The usage especially in driver code is deprecated and a tree wide
effort to clean up and consolidate the (ab)usage of in_interrupt() and
related checks is happening.

hfa384x_cmd() and prism2_hw_reset() check in_interrupt() at function entry
and if true emit a printk at debug loglevel and return. This is clearly debug
code.

Both functions invoke functions which can sleep. These functions already
have appropriate debug checks which cover all invalid contexts, while
in_interrupt() fails to detect context which just has preemption or
interrupts disabled.

Remove both checks as they are incomplete, debug only and already covered
by the subsequently invoked functions properly. If called from invalid
context the resulting back trace is definitely more helpful to analyze the
problem than a printk at debug loglevel.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-09-29 14:02:55 -07:00
..
hostap_80211_rx.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hostap_80211_tx.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hostap_80211.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hostap_ap.c hostap: hostap_ap: Mark 'txt' as __always_unused 2020-09-01 12:02:41 +03:00
hostap_ap.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hostap_common.h hostap: Replace zero-length array with flexible-array member 2020-03-23 18:59:15 +02:00
hostap_config.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hostap_cs.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
hostap_download.c hostap: convert to struct proc_ops 2020-03-26 21:23:28 +02:00
hostap_hw.c net: hostap: Remove in_interrupt() usage 2020-09-29 14:02:55 -07:00
hostap_info.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
hostap_ioctl.c hostap: Remove set but unused variable 'hostscan' 2020-09-01 12:06:21 +03:00
hostap_main.c netdev: pass the stuck queue to the timeout handler 2019-12-12 21:38:57 -08:00
hostap_pci.c hostap: use generic power management 2020-08-02 18:18:15 +03:00
hostap_plx.c hostap: use %*ph to print small buffer 2019-09-06 17:12:02 +03:00
hostap_proc.c hostap: Add missing annotations for prism2_bss_list_proc_start() and prism2_bss_list_proc_stop 2020-04-15 11:42:22 +03:00
hostap_wlan.h hostap: Replace zero-length array with flexible-array member 2020-03-23 18:59:15 +02:00
hostap.h hostap: Mark 'freq_list' as __maybe_unused 2020-09-01 12:02:33 +03:00
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00