proxmox-mirrors/mirror_ubuntu-kernels
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_ubuntu-kernels.git synced 2025-11-10 21:35:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0

Browse Source 
The callers never check for negative but they sometimes check for zero
returns:

	int reg = ADT7462_REG_VOLT_MAX(data, i);
        data->volt_max[i] =
		(reg ? i2c_smbus_read_byte_data(client, reg) : 0);

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Dan Carpenter 2013-08-14 12:45:26 +03:00 committed by Guenter Roeck
parent 60c1f31fc5
commit a4bf06d58f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/adt7462.c
View File

@ -333,7 +333,7 @@ static int ADT7462_REG_VOLT_MAX(struct adt7462_data *data, int which)
return 0x4C; return 0x4C;
break; break;
} }
return -ENODEV; return 0;
} }
static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which) static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which)
@ -392,7 +392,7 @@ static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which)
return 0x77; return 0x77;
break; break;
} }
return -ENODEV; return 0;
} }
static int ADT7462_REG_VOLT(struct adt7462_data *data, int which) static int ADT7462_REG_VOLT(struct adt7462_data *data, int which)