proxmox-mirrors/mirror_ubuntu-kernels
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_ubuntu-kernels.git synced 2025-11-25 18:39:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

backlight: lcd: Constify lcd_ops

Browse Source 
'struct lcd_ops' passed in lcd_device_register() is not modified by core
backlight code, so it can be made const for code safety.  This allows
drivers to also define the structure as const.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-1-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2024-04-24 08:33:27 +02:00 committed by Lee Jones
parent 4cece76496
commit a2e25c8165
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/video/backlight/lcd.c
View File

@ -188,7 +188,7 @@ ATTRIBUTE_GROUPS(lcd_device);
* or a pointer to the newly allocated device. * or a pointer to the newly allocated device.
*/ */
struct lcd_device *lcd_device_register(const char *name, struct device *parent, struct lcd_device *lcd_device_register(const char *name, struct device *parent,
void *devdata, struct lcd_ops *ops) void *devdata, const struct lcd_ops *ops)
{ {
struct lcd_device *new_ld; struct lcd_device *new_ld;
int rc; int rc;
@ -276,7 +276,7 @@ static int devm_lcd_device_match(struct device *dev, void *res, void *data)
*/ */
struct lcd_device *devm_lcd_device_register(struct device *dev, struct lcd_device *devm_lcd_device_register(struct device *dev,
const char *name, struct device *parent, const char *name, struct device *parent,
void *devdata, struct lcd_ops *ops) void *devdata, const struct lcd_ops *ops)
{ {
struct lcd_device **ptr, *lcd; struct lcd_device **ptr, *lcd;

6
include/linux/lcd.h
View File

@ -61,7 +61,7 @@ struct lcd_device {
points to something in the body of that driver, it is also invalid. */ points to something in the body of that driver, it is also invalid. */
struct mutex ops_lock; struct mutex ops_lock;
/* If this is NULL, the backing module is unloaded */ /* If this is NULL, the backing module is unloaded */
struct lcd_ops *ops; const struct lcd_ops *ops;
/* Serialise access to set_power method */ /* Serialise access to set_power method */
struct mutex update_lock; struct mutex update_lock;
/* The framebuffer notifier block */ /* The framebuffer notifier block */
@ -102,10 +102,10 @@ static inline void lcd_set_power(struct lcd_device *ld, int power)
} }
extern struct lcd_device *lcd_device_register(const char *name, extern struct lcd_device *lcd_device_register(const char *name,
struct device *parent, void *devdata, struct lcd_ops *ops); struct device *parent, void *devdata, const struct lcd_ops *ops);
extern struct lcd_device *devm_lcd_device_register(struct device *dev, extern struct lcd_device *devm_lcd_device_register(struct device *dev,
const char *name, struct device *parent, const char *name, struct device *parent,
void *devdata, struct lcd_ops *ops); void *devdata, const struct lcd_ops *ops);
extern void lcd_device_unregister(struct lcd_device *ld); extern void lcd_device_unregister(struct lcd_device *ld);
extern void devm_lcd_device_unregister(struct device *dev, extern void devm_lcd_device_unregister(struct device *dev,
struct lcd_device *ld); struct lcd_device *ld);