proxmox-mirrors/mirror_novnc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_novnc synced 2025-08-10 14:32:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add safety check in code for moving the handle

Browse Source 
An element that has 'display: none' has a height of zero, and the logic
for the handle assumed that this was never the case. This could cause
the handle to end up at the wrong coordinates.
This commit is contained in:
Samuel Mannehed 2016-10-18 13:32:00 +02:00
parent 59cd99bc38
commit f75e4d3caa
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/ui.js
View File

@ -556,6 +556,11 @@ var UI;
.getBoundingClientRect(); .getBoundingClientRect();
var margin = 10; var margin = 10;
// These heights need to be non-zero for the below logic to work
if (handleHeight === 0 || controlbarBounds.height === 0) {
return;
}
var newY = viewportRelativeY; var newY = viewportRelativeY;
// Check if the coordinates are outside the control bar // Check if the coordinates are outside the control bar