Commit Graph

6772 Commits

Author SHA1 Message Date
Christian Brauner
96e6f37f51
cgfsng: cg_hybrid_init()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:20:23 +01:00
Christian Brauner
0f71dd9b92
cgfsng: lxc_cgfsng_print_basecg_debuginfo()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:18:08 +01:00
Christian Brauner
27d8473757
cgfsng: lxc_cgfsng_print_hierarchies()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:17:43 +01:00
Christian Brauner
7689dfd735
cgfsng: trim()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:16:56 +01:00
Christian Brauner
6dfb18bf04
cgfsng: must_append_string()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:16:20 +01:00
Christian Brauner
c3ef912e97
cgfsng: cg_hybrid_get_current_cgroup()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:15:52 +01:00
Christian Brauner
bced39de18
cgfsng: controller_in_clist()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:15:17 +01:00
Christian Brauner
f523291e3e
cgfsng: copy_to_eol()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:14:48 +01:00
Christian Brauner
798c3b33f6
cgfsng: cg_hybrid_get_mountpoint()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:14:14 +01:00
Christian Brauner
f205f10cf6
cgfsng: cg_hybrid_get_controllers()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:12:51 +01:00
Christian Brauner
e1c27ab0f9
cgfsng: all_controllers_found()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:10:49 +01:00
Christian Brauner
f57ac67f66
cgfsng: controller_found()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:09:50 +01:00
Christian Brauner
258449e596
cgfsng: controller_list_is_dup()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:09:18 +01:00
Christian Brauner
5c0089ae61
cgfsng: controller_lists_intersect()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:08:38 +01:00
Christian Brauner
7793add32c
cgfsng: cg_legacy_handle_cpuset_hierarchy()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:07:56 +01:00
Christian Brauner
b095a8ebbb
cgfsng: copy_parent_file()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:04:05 +01:00
Christian Brauner
59ac3b88d8
cgfsng: cg_legacy_filter_and_set_cpus()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:00:33 +01:00
Christian Brauner
333987b9e5
cgfsng: get_max_cpus()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 18:55:15 +01:00
Christian Brauner
414c6719d5
cgfsng: lxc_cpumask_to_cpulist()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 18:54:10 +01:00
Christian Brauner
d5d468f6f0
cgfsng: lxc_cpumask()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:16:52 +01:00
Christian Brauner
5ae0207c84
cgfsng: get_hierarchy()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:12:30 +01:00
Christian Brauner
42a993b470
cgfsng: must_append_controller()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:11:05 +01:00
Christian Brauner
8073018da7
cgfsng: string_in_list()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:09:26 +01:00
Christian Brauner
8b8db2f6af
cgfsng: append_null_to_list()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:08:58 +01:00
Christian Brauner
3fd0de4d30
cgfsng: add me to authors
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:08:06 +01:00
Christian Brauner
ac01094430
cgfsng: move cg_legacy_must_prefix_named()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:06:56 +01:00
Christian Brauner
7745483dbd
cgfsng: cg_legacy_must_prefix_named()
s/must_prefix_named/cg_legacy_must_prefix_named/

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 17:03:38 +01:00
Christian Brauner
2d5fe5bad0
cgfsng: free_string_list()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 16:51:03 +01:00
Christian Brauner
09f3bb13cc
cgfsng: fully document remaining variables
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 16:50:27 +01:00
Christian Brauner
16a2cde9e0
cgfsng: fully document struct cgfsng_handler_data
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 16:45:01 +01:00
Christian Brauner
9e28830178
cgfsng: fully document struct hierarchy
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 16:37:35 +01:00
Christian Brauner
438c4581b0
cgfsng: order includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 16:32:16 +01:00
Christian Brauner
f6a248c024
Merge pull request #2174 from brauner/2018-02-17/lxc-update-config_check_empty_args
cmd/lxc-update-config: check for empty arguments
2018-02-17 13:37:20 +01:00
Christian Brauner
a514f2d943
cmd/lxc-update-config: check for empty arguments
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 13:36:31 +01:00
Christian Brauner
18b1b540e7
Merge pull request #2173 from brauner/2018-02-17/add_coverity_status
README: add coverity
2018-02-17 13:08:32 +01:00
Christian Brauner
0577a33d33
README: add coverity
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 13:07:14 +01:00
Serge Hallyn
3d7868ae53
Merge pull request #2171 from brauner/2018-02-16/rework_hooks
conf: fix run_script_argv()
2018-02-16 18:51:56 -06:00
Christian Brauner
c06a0555e9
console: ensure that fd is marked EBADF
If the handler closes the file descriptor for the peer or master fd it is
crucial that we mark it as -EBADF. This will prevent lxc_console_delete()
from calling close() on an already closed file descriptor again. I've
observed the double close in the attach code.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 00:13:10 +01:00
Christian Brauner
0d0d365516
start: don't call close on invalid file descriptor
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 23:18:54 +01:00
Christian Brauner
941138edba
Merge pull request #2172 from stgraber/master
Sabayon fixes
2018-02-16 23:16:19 +01:00
Stéphane Graber
59ee28f21d
lxc-sabayon: Fix handling of eth0
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
2018-02-16 16:50:45 -05:00
Stéphane Graber
9bf5cd8dbb
lxc-sabayon: Remove broken/unused code
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
2018-02-16 16:49:02 -05:00
Christian Brauner
586b1ce72b
conf: s/argsin/argv/ in run_script_argv()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 22:11:19 +01:00
Christian Brauner
6f8d00d279
conf: use malloc() in run_script_argv()
It seems dangerous to use alloca() as the arguments can be of indeterminate
length and we might blow up the stack.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 22:10:06 +01:00
Christian Brauner
327cce76ad
conf: fix run_script_argv()
Make sure that we allocate the buffer **after** we determined how much space we
need in total.
This fixes a SIGBUS/SIGSEGV Stéphane reported on aarch64 and armf.

Reported-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 22:04:35 +01:00
Stéphane Graber
47d4e397da
Merge pull request #2170 from brauner/2018-02-16/cgfsng_force_cgroup_mount
confile: add "force" to cgroup:{mixed,ro,rw}
2018-02-16 14:47:54 -05:00
Christian Brauner
7e50ec0b5f
utils: fix lxc_p{close,open}()
If a file descriptor fd is opened by fdopen() and associated with a stream f
will **not** have been dup()ed. This means that fclose(f) will also close the
fd. So never call close(fd) after fdopen(fd) succeeded.
This fixes a double close() Stéphane and I observed when debugging on aarch64
and armf.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 20:06:48 +01:00
Christian Brauner
e99cf4acfd
tests: remove lxc-test-ubuntu
This is really taking a long time for not a lot of benefit.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 16:02:09 +01:00
Christian Brauner
ed06b69ce6
CODING_STYLE: add section for str{n}cmp()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 16:02:08 +01:00
Christian Brauner
8353b4c90e
conf: non-functional changes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-16 16:02:08 +01:00