Christian Brauner
a64902abe3
attach: move attach_clone_payload into tighter scope
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 13:14:37 +01:00
Christian Brauner
cb2420df26
attach: s/close/close_prot_errno_disarm/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 13:11:24 +01:00
Christian Brauner
6d6bfd4f6c
configure: fix static builds with clang-12 and LTO
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 13:04:58 +01:00
Christian Brauner
a588a482d9
attach: move getcwd() into tighter scope
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 11:43:23 +01:00
Christian Brauner
53bca1f3c0
attach: remove obsolete namespace check
...
We're not going to support kernel without namespaces anyway.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 11:40:07 +01:00
Christian Brauner
ee142207d4
attach: fix personality handling
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 11:31:53 +01:00
Christian Brauner
4eb19ac075
lsm: s/lsm_init/lsm_init_static/g
...
Make it clear that there is nothing to free here.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-29 10:20:15 +01:00
Christian Brauner
677e1d2769
attach: s/lxc_attach_drop_privs/drop_capabilities/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:34 +01:00
Christian Brauner
7e995801f8
attach: s/lxc_proc_close_ns_fd/close_nsfds/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:33 +01:00
Christian Brauner
b7873c951e
attach: add get_attach_context_nsfds()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:32 +01:00
Christian Brauner
1874ef7468
attach: move config init into get_attach_context()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:31 +01:00
Christian Brauner
d92c8e40d1
attach: move get_personality() into get_attach_context()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:30 +01:00
Christian Brauner
500ed81395
attach: move lxc_cmd_get_init_pid() int get_attach_context()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:25 +01:00
Christian Brauner
9745eb8aea
attach: split attach_context into allocation and initialization
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 19:18:16 +01:00
Christian Brauner
89b7bfe3ff
attach: s/calloc/zalloc/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 18:13:54 +01:00
Christian Brauner
dd53c8af7f
attach: rename attach_context helpers
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 18:05:57 +01:00
Christian Brauner
ab919e5fb7
attach: s/lxc_proc_context_info/attach_context/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 18:04:23 +01:00
Christian Brauner
0e304baae8
attach: move lxc_proc_context_info to file local scope
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 17:57:51 +01:00
Christian Brauner
6f9fe5d02c
attach: order variables correctly
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 17:53:44 +01:00
Christian Brauner
5b514ce32b
attach: coding style fixes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-28 17:34:29 +01:00
Stéphane Graber
0fa84a8cd2
Merge pull request #3637 from brauner/2021-01-27/fixes
...
attach: fixes
2021-01-27 20:10:55 -05:00
Christian Brauner
b495984869
attach: add some DEBUG() logging to stdfd dpulication
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:55:02 +01:00
Christian Brauner
578d4b6202
attach: use close_prot_errno_disarm()
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:57 +01:00
Christian Brauner
dab02267f0
attach: make do_attach() void
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:54 +01:00
Christian Brauner
737a8d8515
attach: mark do_attach() as __noreturn
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:51 +01:00
Christian Brauner
16d19b34ea
attach: s/attach_child_main/do_attach/g
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:49 +01:00
Christian Brauner
7444657c87
attach: use free_disarm()
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:47 +01:00
Christian Brauner
7678371439
attach: coding style fixes
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:45 +01:00
Christian Brauner
ad001fb6d7
attach: use __do_close for labelfd
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:43 +01:00
Christian Brauner
4f3b6a85ed
attach: tweak logging
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:40 +01:00
Christian Brauner
e11f5b8c91
attach: use __do_free cleanup macro for cwd
...
but still yield memory immediately once we're done with it to not have it lying
around while the parent process is around.
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:38 +01:00
Christian Brauner
4f25e72fb0
attach: invert child/parent handling
...
This makes it more consistent with th rest of the shared library.
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 20:52:34 +01:00
Stéphane Graber
665fcdf903
Merge pull request #3636 from brauner/2021-01-27/fixes
...
conf: proc and sys mountpoint creation fixes
2021-01-27 11:34:01 -05:00
Christian Brauner
f4bea7cc76
conf: move proc and sys mountpoint creation int lxc_mount_auto_mounts()
...
Fixes: 493e00b68d
("mkdir -p /proc /sys on container startup")
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 16:48:05 +01:00
Christian Brauner
7b371c1e0b
conf: coding style fixes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 16:46:49 +01:00
Christian Brauner
e25af1bc38
conf: fix coding style
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-27 16:16:42 +01:00
Christian Brauner
e9636f4f48
Merge pull request #3634 from motiejus/mkdir-proc-sys
...
mkdir -p /proc /sys on container startup
2021-01-27 15:03:57 +01:00
Motiejus Jakštys
493e00b68d
mkdir -p /proc /sys on container startup
...
some containers don't have it, and strange things happen.
Signed-off-by: Motiejus Jakštys <motiejus@jakstys.lt>
2021-01-27 12:19:15 +02:00
Stéphane Graber
2c64170505
Merge pull request #3633 from brauner/2021-01-25/criu
...
cgroups: fixes and cgroup2 improvements
2021-01-26 11:04:22 -05:00
Christian Brauner
928b065d34
criu: handle cgroup2 freezer
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:58:41 +01:00
Christian Brauner
6dcd6f0284
cgroups: detect and record cgroup2 freezer support
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:35:54 +01:00
Christian Brauner
f914ae08c4
cgroups: rework cg_unified_init()
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:29:21 +01:00
Christian Brauner
09ed8992c5
cgroups: coding style fixes
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:29:18 +01:00
Christian Brauner
9cde8a8ab4
string_utils: add must_make_path_relative()
...
Stolen without shame from my previous implementation in LXCFS.
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:29:14 +01:00
Christian Brauner
d23cb29e64
file_utils: introduce read_file_at()
...
Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-26 15:29:07 +01:00
Stéphane Graber
6f2f65909e
Merge pull request #3632 from brauner/2021-01-25/fixes
...
autotools: update build
2021-01-25 11:29:47 -05:00
Christian Brauner
b59bc011e3
autotools: update build
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-25 17:04:43 +01:00
Christian Brauner
1aaf81c338
configure: add AC_SYS_LARGEFILE checking
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-25 12:51:31 +01:00
Christian Brauner
123ca49e2d
config: update ax_pthread.m4
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-01-25 12:45:09 +01:00
Stéphane Graber
8061dd6e67
Merge pull request #3631 from brauner/2021-01-24/fixes
...
tree-wide: fix compilation with-Wstrict-prototypes -Wold-style-defini…
2021-01-24 21:05:21 -05:00