Commit Graph

7508 Commits

Author SHA1 Message Date
2xsec
8ddce7df13
coverity: #1438236
Resource leak

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-08-06 13:12:00 +09:00
2xsec
d67beb9e83
tools: lxc-unshare: apply default log priority
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-08-06 13:02:15 +09:00
2xsec
03c6d26669
log: add default log priority
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-08-06 13:02:06 +09:00
2xsec
8273ba47c1
log: function cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-08-06 13:01:55 +09:00
Stéphane Graber
3b6fd3271e
Merge pull request #2510 from brauner/2018-08-05/cap_fixes
tree-wide: pass unsigned long to prctl()
2018-08-05 10:18:55 -04:00
Christian Brauner
b81689a103
tree-wide: pass unsigned long to prctl()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-05 14:04:03 +02:00
Stéphane Graber
1a64ff41a1
Merge pull request #2508 from brauner/2018-08-04/cap_fixes
macro: add new macro header, caps: bugfixes, log: bugfixes
2018-08-04 15:55:32 -04:00
Christian Brauner
202a334b47
log: bugfixes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-04 20:49:05 +02:00
Christian Brauner
4e60664a9a
caps: bugfixes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-04 20:23:08 +02:00
Christian Brauner
279c45eed3
macro: add new macro header
This allows us to use a bunch of macros in our static build for init.lxc.static
without having to link against all of utils.{c,h}.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-04 20:11:58 +02:00
Christian Brauner
de7187b613
travis: export CFLAGS=-O0 for coverity
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-04 18:06:11 +02:00
Christian Brauner
7a6ecf65bf
travis: build with -O0 for coverity
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-08-04 17:50:33 +02:00
Stéphane Graber
09ef5d954f
Merge pull request #2505 from brauner/2018-07-31/bugfixes
coverity: #438136
2018-07-31 10:55:16 -04:00
Christian Brauner
a3cf04da4d
READEM: update Serge's mail address
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Serge Hallyn <serge@hallyn.com>
2018-07-31 13:52:12 +02:00
Christian Brauner
aeba3f8005
coverity: #438136
String not null terminated

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-31 10:55:52 +02:00
Christian Brauner
8da51ee9b3
Merge pull request #2503 from tenforward/japanese
doc: Add incompatibility with network type=none into Japanese man
2018-07-31 09:17:47 +02:00
KATOH Yasufumi
e0e360c589 doc: Add incompatibility with network type=none into Japanese man
Update for commit e4b3e36

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>
2018-07-31 16:03:31 +09:00
Stéphane Graber
542d0f26e6
Merge pull request #2499 from brauner/lxc/master
bugfixes
2018-07-30 14:57:23 -04:00
Stéphane Graber
01fc55d5a7
Merge pull request #2475 from brauner/2018-07-16/monitor_signal_pdeath
conf: improve rootfs setup
2018-07-30 14:56:54 -04:00
Stéphane Graber
e6b4213b9e
Merge pull request #2502 from brauner/2018-07-27/fix_max_devpts_option
conf: mount devpts without "max" on EINVAL
2018-07-30 14:56:19 -04:00
Wolfgang Bumiller
dccffc8269 conf: don't return a clobbered errno value
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2018-07-30 20:30:50 +02:00
Christian Brauner
dfbd473039
conf: mount devpts without "max" on EINVAL
The "max" option to devpts got introduced in kernel 3.4.

Closes #2490.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 15:56:05 +02:00
Christian Brauner
7b52bc0bfe
Merge pull request #2500 from akosiaris/patch-1
Unprivileged's incompatibility with type=none docs
2018-07-30 15:32:19 +02:00
Alexandros Kosiaris
e4b3e369f8 Unprivileged's incompatibility with type=none docs
Unprivileged containers are not compatible with sharing the
host namespace due to an inability to mount sysfs. Add docs
in lxc.container.conf to document that out.

Refs #2463

Signed-off-by: Alexandros Kosiaris <akosiaris@gmail.com>
2018-07-30 15:18:27 +03:00
Christian Brauner
81f8706696
caps: handle EINTR in read()
We don't want to link caps.{c,h} against utils.{c,h} for the sake of our static
builds init.lxc.static. This means lxc_write_nointr() will not be available. So
handle it EINTR.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:42 +02:00
Christian Brauner
e0c198063d
log: handle EINTR in read()
We don't want to link log.{c,h} against utils.{c,h} for the sake of our static
builds init.lxc.static. This means lxc_write_nointr() will not be available. So
handle it EINTR.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:41 +02:00
Christian Brauner
a5bc6cb0e0
utils: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:39 +02:00
Christian Brauner
72f7c19b1a
terminal: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:37 +02:00
Christian Brauner
802e609aa9
monitor: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:35 +02:00
Christian Brauner
2a71131d33
monitor: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:34 +02:00
Christian Brauner
1fabf7d4ca
apparmor: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:33 +02:00
Christian Brauner
8367b31ea5
tools: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:32 +02:00
Christian Brauner
7b6f89cd4c
tools: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:31 +02:00
Christian Brauner
03876f90e2
sync: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:30 +02:00
Christian Brauner
ba38ff8e41
sync: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:29 +02:00
Christian Brauner
f640cf4606
network: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:28 +02:00
Christian Brauner
c72cda4ea4
network: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:27 +02:00
Christian Brauner
3e1e9db834
lxccontainer: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:26 +02:00
Christian Brauner
2a2a676d04
lxccontainer: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:25 +02:00
Christian Brauner
614be9bcec
criu: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:24 +02:00
Christian Brauner
668ba602ab
criu: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:22 +02:00
Christian Brauner
243fdadf8c
cmd: s/read()/lxc_read_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:21 +02:00
Christian Brauner
ff50dd77b4
cmd: s/write()/lxc_write_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:19 +02:00
Christian Brauner
04dc1c0078
cmd: s/pipe()/pipe2()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:18 +02:00
Christian Brauner
0ac84f04d1
lxccontainer: s/pipe()/pipe2()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:17 +02:00
Christian Brauner
9f4866a6f2
lxccontainer: cleanup do_lxcapi_get_interfaces()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:16 +02:00
Christian Brauner
de31cb57c2
criu: s/pipe()/pipe2()/
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:15 +02:00
Christian Brauner
adaffdd7a6
conf: always close pipe in run_userns_fn()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:14 +02:00
Christian Brauner
979f9e34c3
conf: s/pipe()/pipe2()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-30 00:16:13 +02:00
Christian Brauner
646b1be9bb
Merge pull request #2497 from brauner/2018-07-29/nl_fix
nl: avoid NULL pointer dereference
2018-07-29 18:46:42 +02:00