9423 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Christian Brauner	50e3e83d37	tree-wide: this is all rather TODO than FIXME ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-07 14:54:31 +02:00
Stéphane Graber	424886b115	Merge pull request #3399 from brauner/2020-05-09/compiler_hardening ... compiler: more hardening	2020-05-05 10:11:27 -04:00
Christian Brauner	674c969298	compiler: support new access attributes ... which will allow us to catch more oob accesses. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-05 14:04:34 +02:00
Christian Brauner	6acf25e36a	gcc: add -Warray-bounds, -Wrestrict, -Wreturn-local-addr, -Wstringop-overflow ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-05 09:21:33 +02:00
Stéphane Graber	a4327f2aa1	Merge pull request #3398 from brauner/2020-05-04/fixes ... terminal: remove unneeded if condition	2020-05-04 13:38:43 -04:00
Christian Brauner	af25cae409	terminal: remove unneeded if condition ... Fixes: Coverity 1461742. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-04 15:50:41 +02:00
Stéphane Graber	466b8e7f20	Merge pull request #3397 from brauner/2020-05-03/fixes ... conf: introduce userns_exec_mapped_root()	2020-05-04 09:39:34 -04:00
Christian Brauner	cf68ffd9e2	conf: support console setup on containers without rootfs ... This depends on the new mount api. Closes #3164. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-04 13:26:43 +02:00
Christian Brauner	234998b4f2	conf: introduce userns_exec_mapped_root() ... to avoid the overhead of calling to lxc-usernsexec whenever we can. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-04 10:56:05 +02:00
Stéphane Graber	33b8e598f1	Merge pull request #3396 from brauner/2020-05-03/fixes ... cgroup: fixes	2020-05-03 09:51:44 -04:00
Christian Brauner	4547e73e3e	cgroups: premount cgroups on cgroup2-only systems ... Fixes: #3183 Cc: Thomas Moschny <thomas.moschny@gmx.de> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-03 14:08:11 +02:00
Christian Brauner	8dd7f9052f	common.conf: add cgroup2 default device limits ... Fixes: #3183 Cc: Thomas Moschny <thomas.moschny@gmx.de> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-03 12:03:29 +02:00
Christian Brauner	0e7a013ee8	cgroups: ignore cgroup2 limits on non-cgroup2 layouts ... Mixing cgroup2 and legacy cgroup systems such that some controllers are enabled in legacy cgroup hierarchies and other controllers in the unified hierarchies is simply not something we're supporting. Even systemd's hybrid layout (crazy) doesn't bind controllers to the unified cgroup hierarchy. Fixes: #3183 Cc: Thomas Moschny <thomas.moschny@gmx.de> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-05-03 11:59:15 +02:00
Christian Brauner	95d4c1c425	Merge pull request #3392 from tomponline/tp-ipvlan-netlink ... src/lxc/network: Fixes netlink attribute type 1 has an invalid length message	2020-04-22 12:01:42 +02:00
Thomas Parrott	3a934e2e53	src/lxc/network: Fixes netlink attribute type 1 has an invalid length message ... Fixes #3386 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>	2020-04-22 10:12:06 +01:00
Christian Brauner	1bfaf96fd0	Merge pull request #3391 from stgraber/master ... apparmor: Allow boot_id	2020-04-21 19:14:10 +02:00
Stéphane Graber	863845075d	apparmor: Allow boot_id ... Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>	2020-04-21 13:09:07 -04:00
Christian Brauner	538337ee9d	configure: fix coverity builds ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-16 10:03:45 +02:00
Stéphane Graber	4fa41f3562	Merge pull request #3385 from brauner/2020-04-15/fixes ... cgroups: fix cgroup limit braino	2020-04-15 17:39:18 -04:00
Christian Brauner	92afbe74c4	cgroups: fix cgroup limit braino ... Fixes: https://discuss.linuxcontainers.org/t/memory-limits-no-longer-being-applied/7429/7 Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 23:15:49 +02:00
Stéphane Graber	2c46eaeda7	Merge pull request #3384 from brauner/master ... travis: coverity gets confused about the %m printf extension in glibc	2020-04-15 15:41:05 -04:00
Christian Brauner	64a2547c0a	travis: coverity gets confused about the %m printf extension in glibc ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 21:27:53 +02:00
Stéphane Graber	b3e27ad413	Merge pull request #3383 from brauner/2020-04-15/fixes ... log: set GNU_SOURCE as it might help coverity along	2020-04-15 10:55:20 -04:00
Christian Brauner	b10cb59b30	log: set GNU_SOURCE as it might help coverity along ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 15:55:57 +02:00
Stéphane Graber	2c6e89857a	Merge pull request #3382 from brauner/2020-04-15/fixes ... conf: correctly cleanup memory in get_minimal_idmap()	2020-04-15 09:24:51 -04:00
Christian Brauner	47649d5bba	conf: correctly cleanup memory in get_minimal_idmap() ... Fixes: Coverity 1461760. Fixes: Coverity 1461762. Fixes: Coverity 1461763. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:54:35 +02:00
Stéphane Graber	55785a2cf2	Merge pull request #3381 from brauner/2020-04-15/fixes ... fixes	2020-04-15 08:38:10 -04:00
Christian Brauner	0212dc6f33	rexec: free argv array on failure ... Fixes: Coverity 1461736. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:31 +02:00
Christian Brauner	a9909116bc	attach: move check for valid config earlier ... Fixes: Coverity 1461735. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:31 +02:00
Christian Brauner	ad9ea93929	log: restore non-local value ... Fixes: Coverity 1461734. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:31 +02:00
Christian Brauner	40a220433f	network: log warning on network deconfiguration failures ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:31 +02:00
Christian Brauner	7792a5b60f	commands: add additional check to lxc_cmd_sock_get_state() ... to please Coverity. Fixes: Coverity 1461732. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:30 +02:00
Christian Brauner	c148bb7d9f	zfs: fix resource leak ... Fixes: Coverity 1461730. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:30 +02:00
Christian Brauner	f075e955d1	criu: make explicit that we're ignoring rmdir() return value ... Fixes: Coverity 1461726. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:30 +02:00
Christian Brauner	2c99621932	conf: don't double free in get_minimal_idmap() ... Fixes: Coverity 1461725. Fixes: Coverity 1461727. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:30 +02:00
Christian Brauner	7484656d63	cgroups: use correct NULL pointer check ... Fixes: Coverity 1461722. Fixes: Coverity 1461737. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 14:10:22 +02:00
Christian Brauner	67e724615c	rexec: avoid double-close ... Fixes: Coverity 1461721. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 13:42:41 +02:00
Christian Brauner	cd86470685	cgroups: fix cgroup2 devices ... Fixes: Coverity 1461748. Fixes: Coverity 1461746. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 13:37:51 +02:00
Christian Brauner	e84e4a989d	uuid: close fd ... Fixes: Coverity 1461751. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 11:59:57 +02:00
Christian Brauner	83b25c4d37	cgroups: do not pass NULL pointer ... Fixes: Coverity 1461752. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 11:56:54 +02:00
Christian Brauner	e0624f70fc	Merge pull request #3380 from brauner/2020-04-15/fixes ... fixes	2020-04-15 11:45:57 +02:00
Christian Brauner	586a3fe820	conf: fix tty cleanup ... Fixes: Coverity 1461755. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 11:32:48 +02:00
Christian Brauner	ba7536c070	memory_utils: directly NULL ptr in free_disarm() ... This should keep coverity happy. Fixes: Coverity 1461757. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 11:15:56 +02:00
Christian Brauner	3aff3a1490	Merge pull request #3379 from brauner/upstream/master ... travis: add back coverity	2020-04-15 11:00:48 +02:00
Christian Brauner	9e13595366	travis: add back coverity ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-15 10:50:59 +02:00
Stéphane Graber	ff81e0ac1a	Merge pull request #3378 from brauner/2020-04-13/fixes ... cgroups: adhere to boolean return	2020-04-13 11:24:24 -04:00
Christian Brauner	ec4d463d0f	cgroups: adhere to boolean return ... Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>	2020-04-13 14:39:18 +02:00
Christian Brauner	e1141de44e	Merge pull request #3377 from lifeng68/fix_cgroup_exit ... cgroup: fix wrong use of cgfd_con in cgroup_exit	2020-04-13 08:59:58 +02:00
LiFeng	5305cd4e7a	cgroup: fix wrong use of cgfd_con in cgroup_exit ... Signed-off-by: LiFeng <lifeng68@huawei.com>	2020-04-13 12:52:30 +08:00
Stéphane Graber	16e62936a6	Merge pull request #3376 from toddnni/lxc-oci-fix ... Fix lxc-oci template with loop backingstore	2020-04-12 22:59:45 -04:00