Christian Brauner
94fd0bd685
Merge pull request #2466 from flx42/fix-define-argument
...
confile: fix incorrect strncmp
2018-07-14 02:09:46 +02:00
Felix Abecassis
85d49873a6
confile: fix incorrect strncmp
...
Passing additional configuration options with "--define" was broken.
Result of git bisect:
d899f11b7b
is the first bad commit
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
2018-07-13 16:45:55 -07:00
Christian Brauner
5c784312b9
Merge pull request #2465 from 2xsec/bugfix
...
lxclock: change error log using strerror to SYSERROR
2018-07-13 14:50:01 +02:00
2xsec
79cda71dc9
lxclock: change error log using strerror to SYSERROR
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-13 21:33:09 +09:00
Stéphane Graber
7437036726
Merge pull request #2462 from brauner/2018-07-12/coverity
...
coverity
2018-07-12 12:40:34 -04:00
Christian Brauner
a0ee564f64
coverity: #1437935
...
Unchecked return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:52:09 +02:00
Christian Brauner
00c72a935f
coverity: #1437936
...
Unchecked return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:49:30 +02:00
Stéphane Graber
99c42eaad5
Merge pull request #2459 from brauner/2018-07-11/cleanup_makefile
...
autotool fixes, attach cleanups
2018-07-12 11:30:45 -04:00
Stéphane Graber
4017e68046
Merge pull request #2460 from brauner/2018-07-12/handle_new_mknod_smarter
...
conf: handle partially functional device nodes
2018-07-12 10:08:44 -04:00
Christian Brauner
ae026f5593
attach: cleanup log messages in lxc_attach()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 13:06:45 +02:00
Christian Brauner
3f62938a8a
attach: use fd_cloexec()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 13:06:45 +02:00
Christian Brauner
bcbef73392
attach: cleanup no_new_privs()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 13:06:45 +02:00
Christian Brauner
d4db3d1441
attach: cleanup fetch_seccomp()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 13:06:45 +02:00
Christian Brauner
3fa23ac32e
attach: simplify lxc_attach_getpwshell()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 13:06:45 +02:00
Christian Brauner
5067e4dd85
conf: handle partially functional device nodes
...
This improves handling kernels which allow userspace to create partially
functional devices nodes.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 12:43:34 +02:00
Christian Brauner
337fa8eadf
Merge pull request #2458 from 2xsec/bugfix
...
tools: lxc-ls: fix signed_to_bigger_unsigned issue
2018-07-11 23:17:34 +02:00
Christian Brauner
ba7bd8c8de
autotools: cleanup Makefile.am
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-11 22:35:44 +02:00
2xsec
3a3dcd3432
tools: lxc-ls: fix signed_to_bigger_unsigned issue
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-11 21:59:18 +09:00
Stéphane Graber
f2c0c2bf9a
Merge pull request #2452 from brauner/2018-07-06/build_static_liblxc
...
static liblxc, always create /dev directory when autodev = 1, open("/dev/null") opportunistically
2018-07-09 19:55:41 -04:00
Christian Brauner
f4c177c3b3
start: don't unconditionally open("/dev/null")
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-10 01:20:29 +02:00
Christian Brauner
87e0e27360
conf: create /dev directory
...
If users specified lxc.autodev = 1 it does not make sense to skip setting up
autodev if /dev does not exist. We rather should create it.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-10 01:20:29 +02:00
Christian Brauner
57d533fb39
autotools: build both a shared and static liblxc
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Tycho Andersen <tycho@tycho.ws>
2018-07-10 01:20:29 +02:00
Christian Brauner
19400b4d46
Merge pull request #2454 from 2xsec/bugfix
...
tools: lxc-unshare: replace write_id_mapping() to the same function in conf.c
2018-07-07 14:11:20 +02:00
2xsec
23ccbdeda8
tools: lxc-unshare: replace write_id_mapping() to the same function in conf.c
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-07 19:52:11 +09:00
Christian Brauner
74dc5be50c
Merge pull request #2453 from 2xsec/bugfix
...
add namespace api
2018-07-06 21:34:34 +02:00
2xsec
d1673d632f
tools: lxc-unshare: replace converting standard identifiers of namespaces to api
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-07 01:20:53 +09:00
2xsec
2d33090fba
tools: lxc-attach: replace converting standard identifiers of namespaces to api
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-07 01:16:41 +09:00
2xsec
42067d1852
namespace: add api to convert namespaces to standard identifiers
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-07 01:10:10 +09:00
Stéphane Graber
7cb6d1b0a8
Merge pull request #2451 from brauner/2018-07-06/bugfixes
...
bugfixes
2018-07-05 23:44:39 -04:00
Christian Brauner
57b1ab6071
tree-wide: set MSG_NOSIGNAL
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 01:22:06 +02:00
Christian Brauner
7288dfb69d
start: declare int array const
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 01:22:06 +02:00
Christian Brauner
ec1dc63394
start: refactor match_stdfds()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 01:10:13 +02:00
Serge Hallyn
5e64d01b6c
Merge pull request #2450 from brauner/2018-07-05/use_mknod
...
conf: use mknod() to create dummy mount targets
2018-07-05 10:56:36 -04:00
Christian Brauner
31ae165567
terminal: don't garble output
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-05 15:37:59 +02:00
Christian Brauner
3b7e332f92
conf: use mknod() to create dummy mount targets
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-05 00:36:12 +02:00
Stéphane Graber
9449f425e7
Merge pull request #2446 from brauner/2018-07-02/log_prefix
...
Logging and cgroup fixes
2018-07-04 12:19:03 -04:00
Christian Brauner
6947153da5
conf: use mknod() to create dummy mount target
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 14:54:15 +02:00
Christian Brauner
77a3980598
conf: safely retrieve path of slave device
...
openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 14:52:54 +02:00
Christian Brauner
615f24ff50
conf: use fd_cloexec()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 14:49:17 +02:00
Christian Brauner
b7b18fc567
cgfsng: respect lxc.cgroup.use
...
If lxc.cgroup.use is specified then only those controllers listed in there will
be used others will be skipped.
Closes #2447 .
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 11:33:15 +02:00
Christian Brauner
15dcdac429
cgroups: remove is_crucial_cgroup_subsystem()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 10:45:14 +02:00
Christian Brauner
62a95a74bf
Merge pull request #2448 from 2xsec/bugfix
...
log: remove the trailing .
2018-07-04 10:15:54 +02:00
2xsec
7d20477698
log: remove the trailing .
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-04 17:01:45 +09:00
Christian Brauner
eba1ae766e
log: cleanup
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-03 12:48:15 +02:00
Christian Brauner
ac2cecc4b8
tree-wide: remove unneeded log prefixes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-03 12:48:13 +02:00
Christian Brauner
9b9374868d
Merge pull request #2445 from 2xsec/bugfix
...
tests: cleanup source codes.
2018-07-03 11:44:15 +02:00
2xsec
6ea8a4365b
tests: cleanup state_server.c
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-03 18:27:11 +09:00
2xsec
dcfbd1c07b
tests: cleanup startone.c
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-03 18:26:40 +09:00
2xsec
63f769f9c5
tests: cleanup snapshot.c
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-03 18:25:54 +09:00
2xsec
70b12b4a83
tests: cleanup shutdowntest.c
...
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-03 18:25:02 +09:00