Christian Brauner
608a39c23d
rexec: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:45:14 +01:00
Christian Brauner
387c1c70a2
network: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:44:38 +01:00
Christian Brauner
d0c6b86e82
mount_utils: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:42:22 +01:00
Christian Brauner
3ca3b23065
monitor: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:41:52 +01:00
Christian Brauner
ff88c2b4af
lxclock: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:40:56 +01:00
Christian Brauner
94aeacb7a3
lxccontainer: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:40:00 +01:00
Christian Brauner
08f7f1fd34
log: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:32:59 +01:00
Christian Brauner
82c24a7306
file_utils: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:30:38 +01:00
Christian Brauner
8eaa5ae36c
criu: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:29:59 +01:00
Christian Brauner
34a51534fd
confile_utils: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:28:07 +01:00
Christian Brauner
3948c2529a
confile: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:27:06 +01:00
Christian Brauner
9bcde680c5
conf: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:24:18 +01:00
Christian Brauner
92e6ae287c
commands_utils: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:18:41 +01:00
Christian Brauner
f51c7eb43e
attach: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:16:34 +01:00
Christian Brauner
0bba27c1b7
cgroups: convert to strnprintf()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:15:15 +01:00
Christian Brauner
66efb199f7
string_utils: add wrapper for snprintf()
...
This let's us avoid the tedious
if (ret < 0 || (size_t)ret >= sizeof(buf))
style of error checking.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-11 10:14:34 +01:00
Stéphane Graber
ff4e462906
Merge pull request #3664 from brauner/2021-02-10/fixes
...
cgroups: fixes
2021-02-10 15:52:59 -05:00
Christian Brauner
25db3f9440
cgroups: log container process entering
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 20:20:34 +01:00
Christian Brauner
ebf88e5b87
cgroups: log monitor and transient process entering
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 20:20:34 +01:00
Christian Brauner
d1ee87192e
cgroups: do not return early when entering monitor cgroups
...
This will happen when restoring a container via criu.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 20:20:33 +01:00
Christian Brauner
b3a4286596
cgroups: use brackets to have clear semantics for flags checking
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 20:20:33 +01:00
Stéphane Graber
ae2d267e59
Merge pull request #3663 from brauner/2021-02-10/fixes
...
criu: fixes
2021-02-10 13:41:07 -05:00
Christian Brauner
d9fc9be8f0
criu: handle new cgroup layout
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 13:36:04 +01:00
Christian Brauner
b41a8023b8
criu: lxc_init() already initializes cgroups
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 13:14:11 +01:00
Christian Brauner
92fde26d7b
criu: warn about cgroup hierarchies without controllers
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 13:03:06 +01:00
Christian Brauner
2539492cc9
criu: rework init pid retrieval
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:52:30 +01:00
Christian Brauner
5257b91b6e
criu: use cleanup macro when parsing mount data
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:52:30 +01:00
Christian Brauner
6eff3c0d79
criu: use cleanup macro
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:52:30 +01:00
Christian Brauner
2541dfab38
criu: move logging under lxc_log_trace()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:52:26 +01:00
Christian Brauner
59d8a539d1
criu: massage exec_criu()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:31:01 +01:00
Christian Brauner
ff9edd2d04
criu: mark cgroups methods specific to criu
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:27:51 +01:00
Christian Brauner
9d0e129b54
conf: fix memory leak
...
Fixes: Coverity 1472848
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-10 12:27:50 +01:00
Stéphane Graber
11a3696fda
Merge pull request #3661 from blenk92/iw_error_msg
...
network: Add error message if iw couldn't be found
2021-02-09 10:46:19 -05:00
Stéphane Graber
642429e57b
Merge pull request #3662 from brauner/2021-02-08/fixes
...
conf: expand fd-only setup codepaths
2021-02-09 10:07:28 -05:00
Christian Brauner
58b381117d
conf: kill PATH_MAX bytes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:20 +01:00
Christian Brauner
887ae844d5
conf: kill PATH_MAX bytes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:19 +01:00
Christian Brauner
17d9d07275
tests: add logging to lxc-test-unpriv
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:19 +01:00
Christian Brauner
7369e6bf6d
conf: fd-only tty setup
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:19 +01:00
Christian Brauner
ade356b90c
mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:19 +01:00
Christian Brauner
79ff643d24
conf: rework rootfs pinning
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 21:59:15 +01:00
Max
0ed79f452a
network: Add error message if iw couldn't be found
...
When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.
Signed-off-by: Maximilian Blenk <blenkmax@gmail.com>
2021-02-08 20:42:27 +01:00
Christian Brauner
4806d3b9ec
conf: kill PAT_MAX bytes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 10:22:41 +01:00
Christian Brauner
9c0fd29a5c
conf: kill PATH_MAX bytes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 10:22:41 +01:00
Christian Brauner
48e5dcc85a
conf: don't pass struct lxc_conf
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 10:22:41 +01:00
Christian Brauner
8183f09e00
conf: kill PATH_MAX bytes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 10:22:36 +01:00
Christian Brauner
b28aae045e
conf: s/setup_mount()/setup_mount_fstab()/g
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 09:54:57 +01:00
Christian Brauner
ac11febd37
mount_utils: add locked flag helpers
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-08 09:53:34 +01:00
Stéphane Graber
01149adf72
Merge pull request #3660 from brauner/2021-02-05/fixes_1
...
mount_utils: initialize fd
2021-02-05 17:01:39 -05:00
Christian Brauner
60218ee70b
mount_utils: kill mount_filesystem()
...
We have way better helpers now.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-05 21:49:51 +01:00
Christian Brauner
0d50f2882c
attach: switch to simple mount()
...
At the point where we're remounging proc and sys we're in the container's
namespaces so there's no chance of escape so a simple mount() syscall will
suffice.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-05 21:49:18 +01:00
