Commit Graph

10959 Commits

Author SHA1 Message Date
Stéphane Graber
b6f4863739
Merge pull request #3689 from brauner/2021-02-21/fixes
cgroups: introduce fd-only cgroup attach via LXC_CMD_GET_CGROUP_CTX
2021-02-23 15:08:04 -05:00
Christian Brauner
3a6678c7fb
attach: fix namespace preservation
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 20:36:29 +01:00
Christian Brauner
00df53300b
commands: verify expected file descriptors were sent
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 19:39:36 +01:00
Christian Brauner
8a95cd8271
commands: handle older clients gracefully
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 19:20:21 +01:00
Christian Brauner
7184e9d280
attach: remove additional newline
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 19:05:09 +01:00
Christian Brauner
8af9b5dadb
af_unix: add comment about cast
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 19:00:42 +01:00
Christian Brauner
fb54db2c34
attach: fix unsupported namespaces
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 18:59:07 +01:00
Christian Brauner
254a22e17f
commands: lxc_cmd_add_state_client_callback()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 18:45:22 +01:00
Christian Brauner
d3be623e3c
commands: handle older clients elegantly
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 18:45:19 +01:00
Christian Brauner
ebc548a1ef
commands: send ENOSYS response
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:32 +01:00
Christian Brauner
c071c112d3
cgroups: introduce fd-only cgroup attach
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:32 +01:00
Christian Brauner
ef6e048a03
commands: introduce LXC_CMD_GET_CGROUP_CTX
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:32 +01:00
Christian Brauner
9ec1d9db36
utils: add copy_struct_to_client()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:32 +01:00
Christian Brauner
c965e8015f
log: add syswarn_set()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:31 +01:00
Christian Brauner
d329cda71b
utils: add copy_struct_from_client()
Which is our variant of copy_struct_from_user() that Aleksa and I added to the
kernel.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:31 +01:00
Christian Brauner
a1feaf2944
macro: add min() macro
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:31 +01:00
Christian Brauner
2092492ca6
cgroups: allow cgroup fd batch retrieval
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:31 +01:00
Christian Brauner
f8cc4ae8be
commands: add LXC_CMD_GET_CGROUP_FD
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:30 +01:00
Christian Brauner
9c3eb8d525
commands: introduce rsp_many_fds()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:30 +01:00
Christian Brauner
c2f4008889
commands: introduce rsp_one_fd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:30 +01:00
Christian Brauner
4b5f4bdcde
commands: introduce lxc_cmd_rsp_send_reap()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 16:15:28 +01:00
Christian Brauner
32fd8d4f85
commands: be more explicit during command processing
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 13:57:45 +01:00
Christian Brauner
89420aff36
state: _never_ return NULL from lxc_state2str()
Cc: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 13:57:44 +01:00
Christian Brauner
c674e0f6e7
cgroups: add cgroup_fds() helper
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 13:57:44 +01:00
Christian Brauner
d17c815ded
af_unix: improve SCM_RIGHTS file descriptor retrieval
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-23 13:57:42 +01:00
Christian Brauner
da63ea6b4d
commands: tweak validate_string_request()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:02 +01:00
Christian Brauner
61cebd7a1b
commands: explicitly number enums
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:02 +01:00
Christian Brauner
840eec19c3
cgroups: close dfd_mon but keep dfd_con and dfd_lim open for all cgroup hierarchies
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:02 +01:00
Christian Brauner
d39f72b8b6
cgroups: start stashing all fds
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:02 +01:00
Christian Brauner
7f02fd24f7
cgroups: skip and warn about invalid file descriptors
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:02 +01:00
Christian Brauner
1d5446120b
memory_utils: fix close_equal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-22 21:40:00 +01:00
Stéphane Graber
793996583c
Merge pull request #3688 from brauner/2021-02-19/fixes_2
cgroups: rework cgroup initialization
2021-02-22 14:52:25 -05:00
Christian Brauner
c7a1f72aca
cgroups: handle lxc.cgroup.use global parameter
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:33:43 +01:00
Christian Brauner
b8a4fe1282
cgroups: fix cg_legacy_freeze() return type
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:33:43 +01:00
Christian Brauner
2e85effb00
file_utils: tweak lxc_write_openat()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:33:43 +01:00
Christian Brauner
ca72ccb50f
cgroups: improve utility controller handling
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:32:56 +01:00
Christian Brauner
042f9e9c75
cgroups: s/cgroup2_chown/delegate/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:18:28 +01:00
Christian Brauner
4cd3a76456
cgroups: move cgroup2 parameters into substruct
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 14:15:18 +01:00
Christian Brauner
b1b1a60f16
cgroups: s/container_limit_path/path_lim/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:26:30 +01:00
Christian Brauner
67ed60ce6b
cgroups: s/container_full_path/path_con/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:26:29 +01:00
Christian Brauner
c0af7b1c96
cgroups: s/cgfd_limit/dfd_lim/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:41 +01:00
Christian Brauner
6a32c81772
cgroups: s/cgfd_mon/dfd_mon/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:41 +01:00
Christian Brauner
e33870e511
cgroups: s/cgfd_con/dfd_con/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:41 +01:00
Christian Brauner
a58be2ad8b
cgroups: s/mountpoint/at_mnt/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:41 +01:00
Christian Brauner
44585f1a90
cgroups: s/container_base_path/at_base/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:41 +01:00
Christian Brauner
e18e905394
cgroups: rename cgroupfs mount fd
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 11:25:38 +01:00
Christian Brauner
a9db9474ae
cgroups: simplify and fix mounting on non-cgroup namespace aware kernels
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 01:40:11 +01:00
Christian Brauner
b8572e8c2f
cgroups: introduce cgroup hierarchy type
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 01:28:45 +01:00
Christian Brauner
e821c3b74a
cgroups: remove unused helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 01:25:49 +01:00
Christian Brauner
179754a25e
cgroups: s/add_hierarchy()/cgroup_hierarchy_add()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-02-21 01:09:33 +01:00