Commit Graph

10680 Commits

Author SHA1 Message Date
Edênis Freindorfer Azevedo
1a357f5f89
Refactor __lxc_groups() to __lxc_get_groups().
Make code logic be more clear to what it is being done.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:16 +02:00
Edênis Freindorfer Azevedo
fbdba650a2
Another round of more bash-like syntax.
Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:15 +02:00
Edênis Freindorfer Azevedo
eaeec61d2b
Fix lxc-create completion.
Do not append a name of an existing container.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:14 +02:00
Edênis Freindorfer Azevedo
1a5ba64b06
Add support for comma as a completion word.
For `lxc-ls --groups` and `lxc-autostart --groups`.
Support leading comma, trailing comma, embedded double comma.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:13 +02:00
Edênis Freindorfer Azevedo
a93a4a6748
Refactor __lxc_piped_args.
Use bash functions for common array operations. Keep code logic somewhat
easy to read for bug hunting.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:12 +02:00
Edênis Freindorfer Azevedo
289b75c8b3
Fix lxc-snapshot completion.
For options `-r,--restore` and `-d,--destroy`, we need the container
name to create the list of completion values.

Therefore, it is needed to scan the current command line to check if
there is a container name available.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:11 +02:00
Edênis Freindorfer Azevedo
0b7480790a
Use more bash-like syntax.
Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:11 +02:00
Edênis Freindorfer Azevedo
8fa0b91a43
Add support for container composed names.
When a container name has whitespace in it
(e.g. created by `lxc-create -t download -n "arch linux"` ),
the completion for other commands should be able to work by adding a
backslash to escape it.

Although it may be interesting to support names between quotes, this
would probably means to have to add quotes to all names. Might not be
interesting just due to an edge case.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:10 +02:00
Edênis Freindorfer Azevedo
c942fad901
Add completion output for lxc-ls --fancy-format.
Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:09 +02:00
Edênis Freindorfer Azevedo
2afe512391
Improve name completion handling.
Use regex to handle short option `-n`, since short options can be
combined (e.g. `-nd`) as long as at max one requires an argument.

Also consider the case when the arg for the long option is not given
together with `--name=`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:08 +02:00
Edênis Freindorfer Azevedo
ea35c37f0d
Add compopt call to __lxc_piped_args.
On pair with how other functions do it. Also, be smarter about adding
whitespace when there are no more completions available for the
parameter.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:07 +02:00
Edênis Freindorfer Azevedo
c0e3a76278
Use --running instead of --active.
Commands block if container is frozen.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:05 +02:00
Edênis Freindorfer Azevedo
a248708e73
Fill missing commands on name completion.
Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
2021-10-14 17:26:03 +02:00
Christian Brauner
e7d52b3bcb
build: add tools to meson
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:26:02 +02:00
Christian Brauner
a8c4213157
build: add meson skeleton
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:26:01 +02:00
Christian Brauner
94bdf89bc4
build: make sure _GNU_SOURCE is set
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:57 +02:00
Christian Brauner
1d480c1b3e
lxc: remove "version.h" inclusion
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:55 +02:00
Christian Brauner
97d5f1f110
tests: include "version.h"
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:54 +02:00
Christian Brauner
803247fe96
tree-wide: fix config.h inclusion
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:51 +02:00
Christian Brauner
38431dbd71
tools: fix build warnings
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:50 +02:00
Christian Brauner
8b4312af62
tree-wide: fix lxc header inclusion
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:47 +02:00
Christian Brauner
7bce79c5d1
caps: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:46 +02:00
Christian Brauner
14cfc17935
tools/lxc_start: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:46 +02:00
Christian Brauner
25cf1554b4
arguments: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:45 +02:00
Christian Brauner
d4b0261fa9
initutils: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:44 +02:00
Christian Brauner
037bb4f693
log: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:43 +02:00
Christian Brauner
528a5089e5
initutils: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:43 +02:00
Christian Brauner
ac77bc9742
conf: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:42 +02:00
Christian Brauner
ce774360ff
string_utils: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:41 +02:00
Christian Brauner
310521b086
arguments: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:40 +02:00
Christian Brauner
b726f19b9a
commands_utils: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:40 +02:00
Christian Brauner
e0ffd0d061
file_utils: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:39 +02:00
Christian Brauner
e712874d34
monitor: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:38 +02:00
Christian Brauner
d22477a4bf
nl: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:37 +02:00
Christian Brauner
65906c3edf
uuid: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:37 +02:00
Christian Brauner
91d7105e11
seccomp: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:36 +02:00
Christian Brauner
f432b4e683
lxcmntent: fix fallthrough
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:35 +02:00
Christian Brauner
8e6bc99f60
netns_ifaddrs: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:34 +02:00
Christian Brauner
64703c8bd3
start: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:34 +02:00
Christian Brauner
2aa9e89ab2
utils: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:33 +02:00
Christian Brauner
d79d86cd38
terminal: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:32 +02:00
Christian Brauner
0b2d6d429c
lxccontainer: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:31 +02:00
Christian Brauner
cda1acec91
network: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:30 +02:00
Christian Brauner
57144edd8b
tree-wide: fix public lxc header inclusions
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:29 +02:00
Christian Brauner
a3a94e1af1
commands: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:29 +02:00
Christian Brauner
945f12ebeb
criu: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:28 +02:00
Christian Brauner
82a1732bd7
confile_utils: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:27 +02:00
Christian Brauner
94090bb472
tree-wide: fix attach header inclusion
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:26 +02:00
Christian Brauner
3641e8cd9f
conf: fix array initalization
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:25 +02:00
Christian Brauner
36345059ed
conf: fix struct mount_attr initalization
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2021-10-14 17:25:24 +02:00