Commit Graph

9454 Commits

Author SHA1 Message Date
Christian Brauner
92afbe74c4
cgroups: fix cgroup limit braino
Fixes: https://discuss.linuxcontainers.org/t/memory-limits-no-longer-being-applied/7429/7
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 23:15:49 +02:00
Stéphane Graber
2c46eaeda7
Merge pull request #3384 from brauner/master
travis: coverity gets confused about the %m printf extension in glibc
2020-04-15 15:41:05 -04:00
Christian Brauner
64a2547c0a
travis: coverity gets confused about the %m printf extension in glibc
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 21:27:53 +02:00
Stéphane Graber
b3e27ad413
Merge pull request #3383 from brauner/2020-04-15/fixes
log: set GNU_SOURCE as it might help coverity along
2020-04-15 10:55:20 -04:00
Christian Brauner
b10cb59b30
log: set GNU_SOURCE as it might help coverity along
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 15:55:57 +02:00
Stéphane Graber
2c6e89857a
Merge pull request #3382 from brauner/2020-04-15/fixes
conf: correctly cleanup memory in get_minimal_idmap()
2020-04-15 09:24:51 -04:00
Christian Brauner
47649d5bba
conf: correctly cleanup memory in get_minimal_idmap()
Fixes: Coverity 1461760.
Fixes: Coverity 1461762.
Fixes: Coverity 1461763.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:54:35 +02:00
Stéphane Graber
55785a2cf2
Merge pull request #3381 from brauner/2020-04-15/fixes
fixes
2020-04-15 08:38:10 -04:00
Christian Brauner
0212dc6f33
rexec: free argv array on failure
Fixes: Coverity 1461736.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:31 +02:00
Christian Brauner
a9909116bc
attach: move check for valid config earlier
Fixes: Coverity 1461735.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:31 +02:00
Christian Brauner
ad9ea93929
log: restore non-local value
Fixes: Coverity 1461734.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:31 +02:00
Christian Brauner
40a220433f
network: log warning on network deconfiguration failures
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:31 +02:00
Christian Brauner
7792a5b60f
commands: add additional check to lxc_cmd_sock_get_state()
to please Coverity.

Fixes: Coverity 1461732.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:30 +02:00
Christian Brauner
c148bb7d9f
zfs: fix resource leak
Fixes: Coverity 1461730.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:30 +02:00
Christian Brauner
f075e955d1
criu: make explicit that we're ignoring rmdir() return value
Fixes: Coverity 1461726.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:30 +02:00
Christian Brauner
2c99621932
conf: don't double free in get_minimal_idmap()
Fixes: Coverity 1461725.
Fixes: Coverity 1461727.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:30 +02:00
Christian Brauner
7484656d63
cgroups: use correct NULL pointer check
Fixes: Coverity 1461722.
Fixes: Coverity 1461737.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 14:10:22 +02:00
Christian Brauner
67e724615c
rexec: avoid double-close
Fixes: Coverity 1461721.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 13:42:41 +02:00
Christian Brauner
cd86470685
cgroups: fix cgroup2 devices
Fixes: Coverity 1461748.
Fixes: Coverity 1461746.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 13:37:51 +02:00
Christian Brauner
e84e4a989d
uuid: close fd
Fixes: Coverity 1461751.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 11:59:57 +02:00
Christian Brauner
83b25c4d37
cgroups: do not pass NULL pointer
Fixes: Coverity 1461752.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 11:56:54 +02:00
Christian Brauner
e0624f70fc
Merge pull request #3380 from brauner/2020-04-15/fixes
fixes
2020-04-15 11:45:57 +02:00
Christian Brauner
586a3fe820
conf: fix tty cleanup
Fixes: Coverity 1461755.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 11:32:48 +02:00
Christian Brauner
ba7536c070
memory_utils: directly NULL ptr in free_disarm()
This should keep coverity happy.

Fixes: Coverity 1461757.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 11:15:56 +02:00
Christian Brauner
3aff3a1490
Merge pull request #3379 from brauner/upstream/master
travis: add back coverity
2020-04-15 11:00:48 +02:00
Christian Brauner
9e13595366
travis: add back coverity
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-15 10:50:59 +02:00
Stéphane Graber
ff81e0ac1a
Merge pull request #3378 from brauner/2020-04-13/fixes
cgroups: adhere to boolean return
2020-04-13 11:24:24 -04:00
Christian Brauner
ec4d463d0f
cgroups: adhere to boolean return
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-13 14:39:18 +02:00
Christian Brauner
e1141de44e
Merge pull request #3377 from lifeng68/fix_cgroup_exit
cgroup: fix wrong use of cgfd_con in cgroup_exit
2020-04-13 08:59:58 +02:00
LiFeng
5305cd4e7a cgroup: fix wrong use of cgfd_con in cgroup_exit
Signed-off-by: LiFeng <lifeng68@huawei.com>
2020-04-13 12:52:30 +08:00
Stéphane Graber
16e62936a6
Merge pull request #3376 from toddnni/lxc-oci-fix
Fix lxc-oci template with loop backingstore
2020-04-12 22:59:45 -04:00
Toni Ylenius
bbd84ff1a7 Fix lxc-oci template with loop backingstore
Move the content of rootfs inside OCI package to rootfs instead of
replacing it, as the directory is used as the mountpoint.

Tested with directory and loop backingstore.

Signed-off-by: Toni Ylenius <toni.ylenius@iki.fi>
2020-04-12 22:31:30 +03:00
Stéphane Graber
0443ed925d
Merge pull request #3375 from brauner/2020-04-12/fixes
cgroups: ignore legacy limits on pure cgroup2 systems
2020-04-12 13:16:02 -04:00
Christian Brauner
e9071702e6
Merge pull request #3374 from stgraber/master
tests/no-new-privs: Don't mess with /etc/lxc
2020-04-12 16:51:20 +02:00
Christian Brauner
b96aa96fe2
cgroups: ignore legacy limits on pure cgroup2 systems
Link: https://github.com/lxc/lxc/issues/3183#issuecomment-612462322
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-12 10:20:39 +02:00
Stéphane Graber
ecf1f1207b
tests/no-new-privs: Don't mess with /etc/lxc
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
2020-04-11 23:05:04 -04:00
Christian Brauner
3d8949788b
Merge pull request #3370 from stgraber/master
lxc-update-config: Fix bad handling of lxc.logfile
2020-04-10 21:09:51 +02:00
Stéphane Graber
71310ccc85
lxc-update-config: Fix bad handling of lxc.logfile
Closes #3369

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
2020-04-10 14:43:37 -04:00
Stéphane Graber
b7b0264251
Merge pull request #3368 from brauner/2020-04-09/fixes
fixes
2020-04-09 09:20:52 -04:00
Christian Brauner
1758c19505
conf: move_ptr() in all cases in mapped_hostid_add()
Closes #3366.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-09 14:30:31 +02:00
Christian Brauner
1c13783ee8
Merge pull request #3367 from tomponline/tp-nic-ipvlan
src/lxc/network: ipvlan comment and code style tweak
2020-04-09 14:13:06 +02:00
Christian Brauner
c6ba8981f5
conf: use macros all around in lxc_map_ids()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-09 12:49:16 +02:00
Christian Brauner
46bc6f2a55
conf: tweak get_minimal_idmap()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-09 12:44:25 +02:00
Thomas Parrott
cf88a8279b src/lxc/network: ipvlan comment and code style tweak
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
2020-04-09 11:35:48 +01:00
Christian Brauner
43e35480c5
Merge pull request #3365 from albatross0/ipvlan_l2
network: Make it possible to set the mode of IPVLAN to L2
2020-04-09 12:25:33 +02:00
KUWAZAWA Takuya
5755765e77 network: Make it possible to set the mode of IPVLAN to L2
Signed-off-by: KUWAZAWA Takuya <albatross0@gmail.com>
2020-04-09 15:40:15 +09:00
Stéphane Graber
8b5f911176
Merge pull request #3362 from brauner/2020-04-07/fixes
lxc_user_nic: fixes
2020-04-08 08:56:41 -04:00
Christian Brauner
060c4d4504
seccomp: newer kernels require the buffer to be zeroed
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-08 14:42:05 +02:00
Christian Brauner
257f04ec37
cgroups: whitespace fixes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-08 10:01:01 +02:00
Christian Brauner
83ddca524f
lxc_user_nic: continue when we failed to find a group
Closes #3361.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2020-04-08 09:18:45 +02:00