proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-03 02:27:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lxc to apply mount options for bind mounts

Browse Source 
Hello all!

    This bug stalked me for a while, but only now it bit me quite
badly... (Lost about an hour of work...)

    So the culprit: inside the fstab file for the `lxc.mount` option I
can use options like `ro` together with `bind`. Unfortunately the
kernel just laughs in my face and ignores any options I've put in
there... :) But not any more: I've updated `./src/lxc/conf.c`
(`mount_file_entries` function) so that when it encounters a `bind`
option it executes it twice (one without any extra options, and a
second time with the remount flag set.)

I've marginally (as in my particular case) tested it and it works.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
This commit is contained in:
Ciprian Dorin, Craciun 2010-06-24 09:47:14 +02:00 committed by Daniel Lezcano
parent a7dff83460
commit e76b8764fa
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/conf.c
View File

@ -799,12 +799,28 @@ static int mount_file_entries(FILE *file)
}
if (mount(mntent->mnt_fsname, mntent->mnt_dir,
mntent->mnt_type, mntflags, mntdata)) {
mntent->mnt_type, mntflags & ~MS_REMOUNT, mntdata)) {
SYSERROR("failed to mount '%s' on '%s'",
mntent->mnt_fsname, mntent->mnt_dir);
goto out;
}
if ((mntflags & MS_REMOUNT) == MS_REMOUNT ||
((mntflags & MS_BIND) == MS_BIND)) {
DEBUG ("remounting %s on %s to respect bind " \
"or remount options",
mntent->mnt_fsname, mntent->mnt_dir);
if (mount(mntent->mnt_fsname, mntent->mnt_dir,
mntent->mnt_type,
mntflags | MS_REMOUNT, mntdata)) {
SYSERROR("failed to mount '%s' on '%s'",
mntent->mnt_fsname, mntent->mnt_dir);
goto out;
}
}
DEBUG("mounted %s on %s, type %s", mntent->mnt_fsname,
mntent->mnt_dir, mntent->mnt_type);