proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-03 07:23:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix lxc-info printing duplicate lines

Browse Source 
When lxc-info's stdout is not line buffered (ie. "lxc-info -n foo |more")
the first three lines will be duplicated. This is because c->get_ips()
comes next and it forks and the child will exit() causing its fds to be
closed which flushes out its (fork duplicated) stdio buffers. The lines are
then duplicated when the parent actually gets around to flushing out its
stdio. This causes problems for programs (such as the lxc-webpanel) which
are popen()ing lxc-info.

The fix here isn't necessarily the right one, but does show what the
problem is. Seems like maybe we should fix this inside of get_ips(), for
other API callers as well.

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
This commit is contained in:
Dwight Engen 2014-04-02 21:13:05 -04:00 committed by Serge Hallyn
parent e13923c711
commit e2426f0bb0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lxc/lxc_info.c
View File

@ -313,6 +313,7 @@ static int print_info(const char *name, const char *lxcpath)
}
if (ips) {
fflush(stdout);
char **addresses = c->get_ips(c, NULL, NULL, 0);
if (addresses) {
char *address;