proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-14 15:29:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make lxc-start-ephemeral Python 3.2-compatible

Browse Source 
On Ubuntu 12.04 LTS with Python 3.2, `lxc-start-ephemeral` breaks as
follows:

    Traceback (most recent call last):
      File "/usr/bin/lxc-start-ephemeral", line 371, in attach_as_user
      File "/usr/lib/python3.2/subprocess.py", line 515, in check_output
      File "/usr/lib/python3.2/subprocess.py", line 732, in __init__
    LookupError: unknown encoding: ANSI_X3.4-1968

This is because `universal_newlines=True` causes `subprocess` to use
`io.TextIOWrapper`, and in versions of Python earlier than 3.3 that
fetched the preferred encoding using `locale.getpreferredencoding()`
rather than `locale.getpreferredencoding(False)`, thereby changing the
locale and causing codecs to be reloaded.  However, `attach_as_user`
runs inside the container and thus can't rely on having access to the
same Python standard library on disk.

The workaround is to decode by hand instead, avoiding the temporary
change of locale.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
This commit is contained in:
Colin Watson 2017-01-26 14:32:08 +00:00
parent 4893a4315c
commit e0e34b7e93
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lxc/tools/lxc-start-ephemeral.in
View File

@ -28,6 +28,7 @@
import argparse import argparse
import gettext import gettext
import lxc import lxc
import locale
import os import os
import sys import sys
import subprocess import subprocess
@ -363,9 +364,14 @@ if os.path.exists("/proc/self/ns/pid"):
if args.user: if args.user:
username = args.user username = args.user
line = subprocess.check_output( # This should really just use universal_newlines=True, but we do
["getent", "passwd", username], # the decoding by hand instead for compatibility with Python
universal_newlines=True).rstrip("\n") # 3.2; that used locale.getpreferredencoding() internally rather
# than locale.getpreferredencoding(False), and the former breaks
# here because we can't reload codecs at this point unless the
# container has the same version of Python installed.
line = subprocess.check_output(["getent", "passwd", username])
line = line.decode(locale.getpreferredencoding(False)).rstrip("\n")
_, _, pw_uid, pw_gid, _, pw_dir, _ = line.split(":", 6) _, _, pw_uid, pw_gid, _, pw_dir, _ = line.split(":", 6)
pw_uid = int(pw_uid) pw_uid = int(pw_uid)
pw_gid = int(pw_gid) pw_gid = int(pw_gid)