proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-26 23:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coverity: #1425758

Browse Source 
Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
This commit is contained in:
Christian Brauner 2018-06-14 22:00:22 +02:00
parent b29e05d629
commit d3ccc04e79
No known key found for this signature in database
GPG Key ID: 8EB056D53EECB12D
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/lxc/conf.c
View File

@ -924,16 +924,9 @@ static int lxc_setup_ttys(struct lxc_conf *conf)
/* If we populated /dev, then we need to create /* If we populated /dev, then we need to create
* /dev/ttyN * /dev/ttyN
*/ */
ret = access(path, F_OK); ret = mknod(path, S_IFREG | 0000, 0);
if (ret < 0) { if (ret < 0) /* this isn't fatal, continue */
ret = creat(path, 0660); ERROR("%s - Failed to create \"%s\"", strerror(errno), path);
if (ret < 0) {
SYSERROR("Failed to create \"%s\"", path);
/* this isn't fatal, continue */
} else {
close(ret);
}
}
ret = mount(tty->name, path, "none", MS_BIND, 0); ret = mount(tty->name, path, "none", MS_BIND, 0);
if (ret < 0) { if (ret < 0) {
@ -941,8 +934,7 @@ static int lxc_setup_ttys(struct lxc_conf *conf)
continue; continue;
} }
DEBUG("Bind mounted \"%s\" onto \"%s\"", tty->name, DEBUG("Bind mounted \"%s\" onto \"%s\"", tty->name, path);
path);
} }
if (!append_ttyname(&conf->ttys.tty_names, tty->name)) { if (!append_ttyname(&conf->ttys.tty_names, tty->name)) {