proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-15 01:31:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lxc-start-ephemeral: Parse passwd directly

Browse Source 
On Ubuntu 15.04, lxc-start-ephemeral's call to pwd.getpwnam always
fails.  While I haven't been able to prove it or track down an exact
cause, I strongly suspect that glibc does not guarantee that you can
call NSS functions after a context switch without re-execing.  (Running
"id root" in a subprocess from the same point works fine.)

It's safer to use getent to extract the relevant line from the passwd
file and parse it directly.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
This commit is contained in:
Colin Watson 2015-09-30 13:37:10 +01:00
parent 4928c7186c
commit c6be89f857
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/lxc-start-ephemeral.in
View File

@ -29,7 +29,6 @@ import argparse
import gettext
import lxc
import os
import pwd
import sys
import subprocess
import tempfile
@ -363,12 +362,17 @@ if os.path.exists("/proc/self/ns/pid"):
if args.user:
username = args.user
user = pwd.getpwnam(username)
os.setgid(user.pw_gid)
os.initgroups(user.pw_name, user.pw_gid)
os.setuid(user.pw_uid)
os.chdir(user.pw_dir)
os.environ['HOME'] = user.pw_dir
line = subprocess.check_output(
["getent", "passwd", username],
universal_newlines=True).rstrip("\n")
_, _, pw_uid, pw_gid, _, pw_dir, _ = line.split(":", 6)
pw_uid = int(pw_uid)
pw_gid = int(pw_gid)
os.setgid(pw_gid)
os.initgroups(username, pw_gid)
os.setuid(pw_uid)
os.chdir(pw_dir)
os.environ['HOME'] = pw_dir
except:
print(_("Unable to switch to user: %s" % username))
sys.exit(1)