proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-16 11:01:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pam-cgfs: ignore the system umask when creating the cgroup hierarchy

Browse Source 
Fixes: #2277
Signed-off-by: Jonathan Calmels <jcalmels@nvidia.com>
This commit is contained in:
Jonathan Calmels 2018-04-16 12:30:33 -07:00
parent 5dfc91865b
commit c4a4578fa0
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/pam/pam_cgfs.c
View File

@ -223,6 +223,20 @@ static bool cgv2_prune_empty_cgroups(const char *user);
static bool cgv2_remove(const char *cgroup); static bool cgv2_remove(const char *cgroup);
static bool is_cgv2(char *line); static bool is_cgv2(char *line);
static int do_mkdir(const char *path, mode_t mode)
{
int saved_errno;
mode_t mask;
int r;
mask = umask(0);
r = mkdir(path, mode);
saved_errno = errno;
umask(mask);
errno = saved_errno;
return (r);
}
/* Create directory and (if necessary) its parents. */ /* Create directory and (if necessary) its parents. */
static bool mkdir_parent(const char *root, char *path) static bool mkdir_parent(const char *root, char *path)
{ {
@ -252,7 +266,7 @@ static bool mkdir_parent(const char *root, char *path)
if (file_exists(path)) if (file_exists(path))
goto next; goto next;
if (mkdir(path, 0755) < 0) { if (do_mkdir(path, 0755) < 0) {
pam_cgfs_debug("Failed to create %s: %s.\n", path, strerror(errno)); pam_cgfs_debug("Failed to create %s: %s.\n", path, strerror(errno));
return false; return false;
} }
@ -1963,7 +1977,7 @@ static bool cgv1_handle_cpuset_hierarchy(struct cgv1_hierarchy *h,
cgpath = must_make_path(h->mountpoint, h->base_cgroup, cgroup, NULL); cgpath = must_make_path(h->mountpoint, h->base_cgroup, cgroup, NULL);
if (slash) if (slash)
*slash = '/'; *slash = '/';
if (mkdir(cgpath, 0755) < 0 && errno != EEXIST) { if (do_mkdir(cgpath, 0755) < 0 && errno != EEXIST) {
pam_cgfs_debug("Failed to create '%s'", cgpath); pam_cgfs_debug("Failed to create '%s'", cgpath);
free(cgpath); free(cgpath);
return false; return false;