diff --git a/src/tests/Makefile.am b/src/tests/Makefile.am index cffc74204..2e7dd5602 100644 --- a/src/tests/Makefile.am +++ b/src/tests/Makefile.am @@ -53,8 +53,11 @@ bin_PROGRAMS = lxc-test-containertests lxc-test-locktests lxc-test-startone \ lxc-test-reboot lxc-test-list lxc-test-attach lxc-test-device-add-remove \ lxc-test-apparmor lxc-test-utils -bin_SCRIPTS = lxc-test-automount lxc-test-autostart lxc-test-cloneconfig \ - lxc-test-createconfig +bin_SCRIPTS = lxc-test-automount \ + lxc-test-autostart \ + lxc-test-cloneconfig \ + lxc-test-createconfig \ + lxc-test-no-new-privs if DISTRO_UBUNTU bin_SCRIPTS += \ @@ -91,6 +94,7 @@ EXTRA_DIST = \ lxc-test-checkpoint-restore \ lxc-test-cloneconfig \ lxc-test-createconfig \ + lxc-test-no-new-privs \ lxc-test-snapdeps \ lxc-test-symlink \ lxc-test-ubuntu \ diff --git a/src/tests/lxc-test-no-new-privs b/src/tests/lxc-test-no-new-privs new file mode 100755 index 000000000..d10e0449a --- /dev/null +++ b/src/tests/lxc-test-no-new-privs @@ -0,0 +1,104 @@ +#!/bin/bash + +# lxc: linux Container library + +# Authors: +# Christian Brauner +# +# This is a test script for PR_SET_NO_NEW_PRIVS + +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. + +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. + +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +set -eux + +DONE=0 +cleanup() { + cd / + lxc-destroy -n c1 -f || true + if [ $DONE -eq 0 ]; then + echo "FAIL" + exit 1 + fi + echo "PASS" +} + +trap cleanup EXIT SIGHUP SIGINT SIGTERM + +mkdir -p /etc/lxc/ +cat > /etc/lxc/default.conf << EOF +lxc.network.type = veth +lxc.network.link = lxcbr0 +EOF + +ARCH=i386 +if type dpkg >/dev/null 2>&1; then + ARCH=$(dpkg --print-architecture) +fi + +lxc-create -t download -n c1 -- -d ubuntu -r xenial -a $ARCH +echo "lxc.no_new_privs = 1" >> /var/lib/lxc/c1/config + +lxc-start -n c1 +p1=$(lxc-info -n c1 -p -H) +[ "$p1" != "-1" ] || { echo "Failed to start container c1 (run $count)"; false; } +sleep 5s +lxc-attach -n c1 --clear-env -- apt update -y +lxc-attach -n c1 --clear-env -- apt install -y gcc make + +# Here documents don't seem to like sudo -i. +lxc-attach -n c1 --clear-env -- /bin/bash -c "cat < /nnptest.c +#include +#include +#include + +int main(int argc, char *argv[]) +{ + printf(\"%d\n\", geteuid()); +} +EOF" +lxc-attach -n c1 --clear-env -- cat /nnptest.c +lxc-attach -n c1 --clear-env -- make -C / nnptest +lxc-attach -n c1 --clear-env -- chmod u+s /nnptest + +# Check that lxc-attach obeys PR_SET_NO_NEW_PRIVS when it is set. +NNP_EUID=$(lxc-attach -n c1 --clear-env -- sudo -u ubuntu /nnptest) +if [ "$NNP_EUID" -ne 1000 ]; then + exit 1 +fi +lxc-stop -n c1 -k + +# Check that lxc-attach obeys PR_SET_NO_NEW_PRIVS when it is not set. +sed -i 's/lxc.no_new_privs = 1/lxc.no_new_privs = 0/' /var/lib/lxc/c1/config +lxc-start -n c1 +NNP_EUID=$(lxc-attach -n c1 --clear-env -- sudo -u ubuntu /nnptest) +if [ "$NNP_EUID" -ne 0 ]; then + exit 1 +fi +lxc-stop -n c1 -k + +# Check that lxc-execute and lxc-start obey PR_SET_NO_NEW_PRIVS when it is set. +NNP_EUID=$(lxc-execute -n c1 -- sudo -u ubuntu /nnptest) +if [ "$NNP_EUID" -ne 0 ]; then + exit 1 +fi + +# Check that lxc-execute and lxc-start obey PR_SET_NO_NEW_PRIVS when it is not set. +sed -i 's/lxc.no_new_privs = 0/lxc.no_new_privs = 1/' /var/lib/lxc/c1/config +NNP_EUID=$(lxc-execute -n c1 -- sudo -u ubuntu /nnptest) +if [ "$NNP_EUID" -ne 1000 ]; then + exit 1 +fi + +DONE=1