proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-27 12:37:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

utils: Copying source filename to avoid missing info.

Browse Source 
Some applications use information from LOOP_GET_STATUS64. The file
associated with loop device is pointed inside structure field
`lo_file_name`. The current code is setting up a loop device without
this information. A legacy example of code checking this is cryptsetup:

    static char *_ioctl_backing_file(const char *loop)
    {
        struct loop_info64 lo64 = {0};
        int loop_fd;

        loop_fd = open(loop, O_RDONLY);
        if (loop_fd < 0)
            return NULL;

        if (ioctl(loop_fd, LOOP_GET_STATUS64, &lo64) < 0) {
            close(loop_fd);
            return NULL;
        }

        lo64.lo_file_name[LO_NAME_SIZE-2] = '*';
        lo64.lo_file_name[LO_NAME_SIZE-1] = 0;

        close(loop_fd);
        return strdup((char*)lo64.lo_file_name);
    }

It will return an empty string because lo_file_name was not set.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
This commit is contained in:
Julio Faracco 2019-09-05 01:43:21 -03:00
parent 13a885dd10
commit a70c9e85a6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lxc/utils.c
View File

@ -1557,6 +1557,8 @@ int lxc_prepare_loop_dev(const char *source, char *loop_dev, int flags)
memset(&lo64, 0, sizeof(lo64)); memset(&lo64, 0, sizeof(lo64));
lo64.lo_flags = flags; lo64.lo_flags = flags;
strlcpy((char *)lo64.lo_file_name, source, LO_NAME_SIZE);
ret = ioctl(fd_loop, LOOP_SET_STATUS64, &lo64); ret = ioctl(fd_loop, LOOP_SET_STATUS64, &lo64);
if (ret < 0) { if (ret < 0) {
SYSERROR("Failed to set loop status64"); SYSERROR("Failed to set loop status64");