From a2eea3c1974d70bdef74a0af6a14ca3a6fa41704 Mon Sep 17 00:00:00 2001 From: Dwight Engen Date: Fri, 3 May 2013 11:29:39 -0400 Subject: [PATCH] coverity: ensure string is null terminated, return in error case Signed-off-by: Dwight Engen Signed-off-by: Serge Hallyn --- src/lxc/lxccontainer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 452323ca1..73c347d46 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -1160,10 +1160,11 @@ static int update_name_and_paths(const char *path, struct lxc_container *oldc, SYSERROR("rewinding old config"); return -1; } - contents = malloc(flen); + contents = malloc(flen+1); if (!contents) { SYSERROR("out of memory"); fclose(f); + return -1; } if (fread(contents, 1, flen, f) != flen) { free(contents); @@ -1171,6 +1172,7 @@ static int update_name_and_paths(const char *path, struct lxc_container *oldc, SYSERROR("reading old config"); return -1; } + contents[flen] = '\0'; if (fclose(f) < 0) { free(contents); SYSERROR("closing old config");