proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-14 11:39:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lxc-monitord.log should not be created with mode 0666

Browse Source 
lxc_monitord_spawn() in src/lxc/monitor.c contained "umask(0);", and
because of this, lxc-monitord created lxc-monitord.log with mode 0666.
World-writeable log files are bad, so remove this umask(0).

Signed-off-by: Robert Vogelgesang <vogel@users.sourceforge.net>
Acked-by: Dwight Engen <dwight.engen@oracle.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
This commit is contained in:
Robert Vogelgesang 2014-01-28 12:01:54 +01:00 committed by Stéphane Graber
parent 1bdedfacc2
commit a27ed52b34
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lxc/monitor.c
View File

@ -325,7 +325,6 @@ int lxc_monitord_spawn(const char *lxcpath)
exit(EXIT_SUCCESS);
}
umask(0);
if (setsid() < 0) {
SYSERROR("failed to setsid");
exit(EXIT_FAILURE);