From a1ac26802cde69dc15e696c9e4b65b0a0561a653 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Mon, 5 Jul 2021 12:19:31 +0200 Subject: [PATCH] lxc_unshare: fix network device handling We were passing the wrong PID. Fix this! Link: https://discuss.linuxcontainers.org/t/problem-with-moving-interface-new-network-namespace-in-lxc-unshare Signed-off-by: Christian Brauner --- src/lxc/tools/lxc_unshare.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lxc/tools/lxc_unshare.c b/src/lxc/tools/lxc_unshare.c index 8e4716cf3..a0ef5f618 100644 --- a/src/lxc/tools/lxc_unshare.c +++ b/src/lxc/tools/lxc_unshare.c @@ -416,7 +416,7 @@ int main(int argc, char *argv[]) if (lpid == 0) { char buf[256]; - ret = snprintf(buf, 256, "%d", lpid); + ret = snprintf(buf, 256, "%d", pid); if (ret < 0 || ret >= 256) _exit(EXIT_FAILURE); @@ -425,8 +425,7 @@ int main(int argc, char *argv[]) } if (wait_for_pid(lpid) != 0) - SYSERROR("Could not move interface \"%s\" into container %d", - ifname, lpid); + SYSERROR("Could not move interface \"%s\" into container %d", ifname, lpid); } free_ifname_list();