From 9de2ebe99503be25dee9ef327e9e16d3ed85fc5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Graber?= Date: Fri, 14 Feb 2014 15:56:28 -0500 Subject: [PATCH] coverity: Check fread length MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn --- src/lxc/console.c | 2 +- src/lxc/lxcutmp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/console.c b/src/lxc/console.c index 55e895cdf..6bfc8a34c 100644 --- a/src/lxc/console.c +++ b/src/lxc/console.c @@ -116,7 +116,7 @@ static int lxc_console_cb_sigwinch_fd(int fd, uint32_t events, void *cbdata, struct signalfd_siginfo siginfo; struct lxc_tty_state *ts = cbdata; - if (read(fd, &siginfo, sizeof(siginfo)) < 0) { + if (read(fd, &siginfo, sizeof(siginfo)) < sizeof(siginfo)) { ERROR("failed to read signal info"); return -1; } diff --git a/src/lxc/lxcutmp.c b/src/lxc/lxcutmp.c index 24cfa7589..ba65654ad 100644 --- a/src/lxc/lxcutmp.c +++ b/src/lxc/lxcutmp.c @@ -167,7 +167,7 @@ static int utmp_handler(int fd, uint32_t events, void *data, return -1; } - if (read(fd, buffer, size) < 0) { + if (read(fd, buffer, size) < size) { SYSERROR("failed to read notification"); return -1; }