proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-15 08:05:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

host consoles/ttys in containers

Browse Source 
I noticed that container's consoles aren't quite useable
(be it lxc-console or lxc-start with getty bound to /dev/console).
The main problem is a complete lack of window resizing support:
when I resize an xterm window with lxc-start or lxc-console, the
"guest" does not know about that and continues to think that the
terminal is 80x25 still.

Is it just a lack of functionality (missing implementation) or
something problematic?
 
Ok, the attached patch fixes this.
 
It moves the 'master' variable out of main function so it's
accessible from the signal handler, sets up SIGWINCH handler
to call a (newly created) winsz() function that gets the
current tty size using TIOCGWINSZ ioctl and if that works,
sets up the pty size using TIOCSWINSZ.  That same function
is called at the start as well, when setting up the signal
handler.

Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-By: Daniel Lezcano <dlezcano@fr.ibm.com>
This commit is contained in:
Michael Tokarev 2009-11-17 10:56:24 +01:00 committed by Daniel Lezcano
parent aef4ebcf22
commit 994f905eed
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/lxc_console.c
View File

@ -36,6 +36,7 @@
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/poll.h>
#include <sys/ioctl.h>
#include <lxc/error.h>
#include <lxc/lxc.h>
@ -74,9 +75,22 @@ Options :\n\
.ttynum = -1,
};
static int master = -1;
static void winsz(void)
{
struct winsize wsz;
if (ioctl(0, TIOCGWINSZ, &wsz) == 0)
ioctl(master, TIOCSWINSZ, &wsz);
}
static void sigwinch(int sig)
{
winsz();
}
int main(int argc, char *argv[])
{
int master = -1;
int wait4q = 0;
int err;
struct termios tios, oldtios;
@ -120,6 +134,8 @@ int main(int argc, char *argv[])
fprintf(stderr, "\nType <Ctrl+a q> to exit the console\n");
setsid();
signal(SIGWINCH, sigwinch);
winsz();
err = 0;