proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-16 23:53:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

conf: improve log when mounting rootfs

Browse Source 
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
This commit is contained in:
Christian Brauner 2017-04-15 18:16:31 +02:00
parent df6a294548
commit 91c3e2814c
No known key found for this signature in database
GPG Key ID: 8EB056D53EECB12D
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/lxc/conf.c
View File

@ -916,29 +916,28 @@ static int mount_rootfs(const char *rootfs, const char *target, const char *opti
}; };
if (!realpath(rootfs, absrootfs)) { if (!realpath(rootfs, absrootfs)) {
SYSERROR("failed to get real path for '%s'", rootfs); SYSERROR("Failed to get real path for \"%s\".", rootfs);
return -1; return -1;
} }
if (access(absrootfs, F_OK)) { if (access(absrootfs, F_OK)) {
SYSERROR("'%s' is not accessible", absrootfs); SYSERROR("Th rootfs \"%s\" is not accessible.", absrootfs);
return -1; return -1;
} }
if (stat(absrootfs, &s)) { if (stat(absrootfs, &s)) {
SYSERROR("failed to stat '%s'", absrootfs); SYSERROR("Failed to stat the rootfs \"%s\".", absrootfs);
return -1; return -1;
} }
for (i = 0; i < sizeof(rtfs_type)/sizeof(rtfs_type[0]); i++) { for (i = 0; i < sizeof(rtfs_type)/sizeof(rtfs_type[0]); i++) {
if (!__S_ISTYPE(s.st_mode, rtfs_type[i].type)) if (!__S_ISTYPE(s.st_mode, rtfs_type[i].type))
continue; continue;
return rtfs_type[i].cb(absrootfs, target, options); return rtfs_type[i].cb(absrootfs, target, options);
} }
ERROR("unsupported rootfs type for '%s'", absrootfs); ERROR("Unsupported rootfs type for rootfs \"%s\".", absrootfs);
return -1; return -1;
} }
@ -1304,38 +1303,45 @@ static int fill_autodev(const struct lxc_rootfs *rootfs, bool mount_console)
static int setup_rootfs(struct lxc_conf *conf) static int setup_rootfs(struct lxc_conf *conf)
{ {
const struct lxc_rootfs *rootfs = &conf->rootfs; struct bdev *bdev;
const struct lxc_rootfs *rootfs;
rootfs = &conf->rootfs;
if (!rootfs->path) { if (!rootfs->path) {
if (mount("", "/", NULL, MS_SLAVE|MS_REC, 0)) { if (mount("", "/", NULL, MS_SLAVE | MS_REC, 0)) {
SYSERROR("Failed to make / rslave"); SYSERROR("Failed to make / rslave.");
return -1; return -1;
} }
return 0; return 0;
} }
if (access(rootfs->mount, F_OK)) { if (access(rootfs->mount, F_OK)) {
SYSERROR("failed to access to '%s', check it is present", SYSERROR("Failed to access to \"%s\". Check it is present.",
rootfs->mount); rootfs->mount);
return -1; return -1;
} }
// First try mounting rootfs using a bdev /* First try mounting rootfs using a bdev. */
struct bdev *bdev = bdev_init(conf, rootfs->path, rootfs->mount, rootfs->options); bdev = bdev_init(conf, rootfs->path, rootfs->mount, rootfs->options);
if (bdev && bdev->ops->mount(bdev) == 0) { if (bdev && !bdev->ops->mount(bdev)) {
bdev_put(bdev); bdev_put(bdev);
DEBUG("mounted '%s' on '%s'", rootfs->path, rootfs->mount); DEBUG("Mounted rootfs \"%s\" onto \"%s\" with options \"%s\".",
rootfs->path, rootfs->mount,
rootfs->options ? rootfs->options : "(null)");
return 0; return 0;
} }
if (bdev) if (bdev)
bdev_put(bdev); bdev_put(bdev);
if (mount_rootfs(rootfs->path, rootfs->mount, rootfs->options)) { if (mount_rootfs(rootfs->path, rootfs->mount, rootfs->options)) {
ERROR("failed to mount rootfs"); ERROR("Failed to mount rootfs \"%s\" onto \"%s\" with options \"%s\".",
rootfs->path, rootfs->mount,
rootfs->options ? rootfs->options : "(null)");
return -1; return -1;
} }
DEBUG("mounted '%s' on '%s'", rootfs->path, rootfs->mount); DEBUG("Mounted rootfs \"%s\" onto \"%s\" with options \"%s\".",
rootfs->path, rootfs->mount,
rootfs->options ? rootfs->options : "(null)");
return 0; return 0;
} }