proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-17 19:27:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lxc-commands: add a comment explaining CMD_* rules

Browse Source 
We wish to ensure that, henceforth, newer lxc tools are always compatible
with older lxc monitors.  Add a comment to commands.c to explain the
rule we wish to enforce to this end.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
This commit is contained in:
Serge Hallyn 2013-09-03 08:08:39 -05:00 committed by Stéphane Graber
parent 0f081315a9
commit 80bcb05357
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/lxc/commands.c
View File

@ -59,6 +59,16 @@
* Each command is wrapped in a ancillary message in order to pass * Each command is wrapped in a ancillary message in order to pass
* a credential making possible to the server to check if the client * a credential making possible to the server to check if the client
* is allowed to ask for this command or not. * is allowed to ask for this command or not.
*
* IMPORTANTLY: Note that semantics for current commands are fixed. If you
* wish to make any changes to how, say, LXC_CMD_GET_CONFIG_ITEM works by
* adding information to the end of cmd.data, then you must introduce a new
* LXC_CMD_GET_CONFIG_ITEM_V2 define with a new number. You may wish to
* also mark LXC_CMD_GET_CONFIG_ITEM deprecated in commands.h.
*
* This is necessary in order to avoid having a newly compiled lxc command
* communicating with a running (old) monitor from crashing the running
* container.
*/ */
lxc_log_define(lxc_commands, lxc); lxc_log_define(lxc_commands, lxc);