proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-27 09:35:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coverity: #1425760

Browse Source 
Use of untrusted scalar value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
This commit is contained in:
Christian Brauner 2018-06-14 22:05:09 +02:00
parent d3ccc04e79
commit 7635665611
No known key found for this signature in database
GPG Key ID: 8EB056D53EECB12D
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lxc/tools/lxc_ls.c
View File

@ -1136,17 +1136,27 @@ static int ls_serialize(int wpipefd, struct ls *n)
static int ls_recv_str(int fd, char **buf) static int ls_recv_str(int fd, char **buf)
{ {
ssize_t ret;
size_t slen = 0; size_t slen = 0;
if (lxc_read_nointr(fd, &slen, sizeof(slen)) != sizeof(slen))
ret = lxc_read_nointr(fd, &slen, sizeof(slen));
if (ret != sizeof(slen))
return -1; return -1;
if (slen > 0) { if (slen > 0) {
*buf = malloc(sizeof(char) * (slen + 1)); *buf = malloc(sizeof(char) * (slen + 1));
if (!*buf) if (!*buf)
return -1; return -1;
if (lxc_read_nointr(fd, *buf, slen) != (ssize_t)slen)
ret = lxc_read_nointr(fd, *buf, slen);
if (ret != (ssize_t)slen) {
free(*buf);
return -1; return -1;
}
(*buf)[slen] = '\0'; (*buf)[slen] = '\0';
} }
return 0; return 0;
} }