From 58d5b5279539b2a8e6be1aaeb2e96295357ac002 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Wed, 10 May 2017 13:27:38 +0200 Subject: [PATCH] start: remove umount2() I really fail to see the point of this and git {blame, log -S} don't really enlighten me on the reason for this as well. But I might be dense. The way I see it the only thing this line achieves is causing trouble when the container is started as root because the umount2() call will umount e.g. /usr/lib/x86_64-linux-gnu/lxc in case it is a mountpoint on the host. Note, this is because lxc_spawn() is still called in the hosts namespaces. Closes https://github.com/lxc/lxd/#3255. Signed-off-by: Christian Brauner --- src/lxc/start.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 61d268ad0..db2a56e71 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -1289,9 +1289,6 @@ static int lxc_spawn(struct lxc_handler *handler) if (lxc_sync_barrier_child(handler, LXC_SYNC_POST_CGROUP)) return -1; - if (detect_shared_rootfs()) - umount2(handler->conf->rootfs.mount, MNT_DETACH); - if (handler->ops->post_start(handler, handler->data)) goto out_abort;