From 3f62938a8a1f53711093c67ef6ebecc899c7651b Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Wed, 11 Jul 2018 23:43:38 +0200 Subject: [PATCH] attach: use fd_cloexec() Signed-off-by: Christian Brauner --- src/lxc/attach.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 9b886af3c..2920872ff 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -930,16 +930,7 @@ static int attach_child_main(struct attach_clone_payload *payload) * here, ignore errors. */ for (fd = STDIN_FILENO; fd <= STDERR_FILENO; fd++) { - int flags; - - flags = fcntl(fd, F_GETFL); - if (flags < 0) - continue; - - if ((flags & FD_CLOEXEC) == 0) - continue; - - ret = fcntl(fd, F_SETFL, flags & ~FD_CLOEXEC); + ret = fd_cloexec(fd, false); if (ret < 0) { SYSERROR("Failed to clear FD_CLOEXEC from file descriptor %d", fd); goto on_error;