proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-08 08:16:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lxc-user-nic: be more paranoid

Browse Source 
Just setting path isn't enough.  Clear the whole environment, and only set
$PATH.  It's all we need - ovs-vsctl is running fine this way.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
This commit is contained in:
Serge Hallyn 2014-08-25 17:50:25 +00:00 committed by Stéphane Graber
parent 8fefbee406
commit 361b4fe7e2
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lxc/lxc_user_nic.c
View File

@ -590,7 +590,11 @@ int main(int argc, char *argv[])
char *vethname = NULL; char *vethname = NULL;
int pid; int pid;
/* set a sane path, because we are setuid-root */ /* set a sane env, because we are setuid-root */
if (clearenv() < 0) {
fprintf(stderr, "Failed to clear environment");
exit(1);
}
if (setenv("PATH", "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin", 1) < 0) { if (setenv("PATH", "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin", 1) < 0) {
fprintf(stderr, "Failed to set PATH, exiting\n"); fprintf(stderr, "Failed to set PATH, exiting\n");
exit(1); exit(1);