proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-07-20 11:00:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coverity: #1425793

Browse Source 
Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
This commit is contained in:
Christian Brauner 2018-06-15 11:42:18 +02:00
parent dd5c5a5d68
commit 2afdc31ff3
No known key found for this signature in database
GPG Key ID: 8EB056D53EECB12D
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/lxc/lxccontainer.c
View File

@ -3429,14 +3429,20 @@ static bool add_rdepends(struct lxc_container *c, struct lxc_container *c0)
bool should_default_to_snapshot(struct lxc_container *c0, bool should_default_to_snapshot(struct lxc_container *c0,
struct lxc_container *c1) struct lxc_container *c1)
{ {
int ret;
size_t l0 = strlen(c0->config_path) + strlen(c0->name) + 2; size_t l0 = strlen(c0->config_path) + strlen(c0->name) + 2;
size_t l1 = strlen(c1->config_path) + strlen(c1->name) + 2; size_t l1 = strlen(c1->config_path) + strlen(c1->name) + 2;
char *p0 = alloca(l0 + 1); char *p0 = alloca(l0 + 1);
char *p1 = alloca(l1 + 1); char *p1 = alloca(l1 + 1);
char *rootfs = c0->lxc_conf->rootfs.path; char *rootfs = c0->lxc_conf->rootfs.path;
snprintf(p0, l0, "%s/%s", c0->config_path, c0->name); ret = snprintf(p0, l0, "%s/%s", c0->config_path, c0->name);
snprintf(p1, l1, "%s/%s", c1->config_path, c1->name); if (ret < 0 || ret >= l0)
return false;
ret = snprintf(p1, l1, "%s/%s", c1->config_path, c1->name);
if (ret < 0 || ret >= l1)
return false;
if (!is_btrfs_fs(p0) || !is_btrfs_fs(p1)) if (!is_btrfs_fs(p0) || !is_btrfs_fs(p1))
return false; return false;