proxmox-mirrors/mirror_lxc
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_lxc synced 2025-08-03 06:01:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix log appending to any file

Browse Source 
With the capabilities, the open of the log file can be done on any
file, making possible to modifify the content of the file.

Let's drop the privilege when opening the file, so we ensure that is
no longer possible.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
This commit is contained in:
Daniel Lezcano 2010-07-20 13:45:44 +02:00
parent 05cda563bf
commit 28f602ff47
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lxc/log.c
View File

@ -33,7 +33,8 @@
#include <fcntl.h>
#include <stdlib.h>
#include <lxc/log.h>
#include "log.h"
#include "caps.h"
#define LXC_LOG_PREFIX_SIZE 32
#define LXC_LOG_BUFFER_SIZE 512
@ -127,7 +128,8 @@ static int log_open(const char *name)
int fd;
int newfd;
fd = open(name, O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC, 0666);
fd = lxc_unpriv(open(name, O_CREAT | O_WRONLY |
O_APPEND | O_CLOEXEC, 0666));
if (fd == -1) {
ERROR("failed to open log file \"%s\" : %s", name,
strerror(errno));